search

Alpha-s-Stuff / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
86 stars 31 forks source link

Step-Assist Modifier (I or II) not working #44

Closed rcshort closed 1 year ago

rcshort commented 1 year ago

Minecraft Version

1.18.2

Fabric/Quilt Version

0.14.14

Fabric/Quilt API Version

0.67.1+1.18.2

Tinkers' Construct Version

1.18.2-3.5.2.150

Describe your issue

After applying Step Up 1 to my leggings, I was still unable to walk onto blocks as if they were stairs.

The "Step Up I" tag is present on my leggings, but the details show a reference to porting_lib. image

After researching, this might extend to that library.

Although I didn't test in an instance with just this mod, I did see this issue present in another modpack.

Crash Report

No response

Other mods

image image image

Tried reproducing with just Tinkers?

No

Performance Enchancers

Sodium

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues

KonSola5 commented 1 year ago

A solution would be to change the attribute to "stepheightentityattribute:stepheight", and depend on step-height-entity-attribute.

AlphaMode commented 1 year ago

Porting Lib already has the attribute so no that wouldn't help, and it would only cause issues for existing worlds. I am going to be fixing most issues once 1.19 is ready, except that might be a while due to upstream wanting to stick to 1.18.2 for a while

KonSola5 commented 1 year ago

So it's up to Porting Lib to fix its Step Height attribute?

AlphaMode commented 1 year ago

It's probably already fixed on 1.19.3, jay is the only one who still maintains 1.18.2 porting lib.

KonSola5 commented 1 year ago

Anyway, modpacks can implement this fix by themselves using a datapack (TConstruct is seriously flexible these days)

AlphaMode commented 1 year ago

Fixed in latest commit