Alpha-s-Stuff / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
85 stars 29 forks source link

Memory leak in CopperCanModel #59

Closed mspielberg closed 1 year ago

mspielberg commented 1 year ago

Minecraft Version

1.18.2

Fabric Version

0.76.0-1.18.2

Hephaestus Version

1.18.2-3.5.2.155

Describe your issue

Due to Fabricators-of-Create/Porting-Lib#50, the cache in CopperCanModel grows without bound, eventually exhausting memory.

Reporting here as well in case you want to fix or work around the issue within Hephaestus as an interim fix until Porting-Lib is fixed.

Crash Report

No response

Other mods

Experienced with Create Astral (CurseForge v2.0.4c.

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

Other (specify under other mods)

Searched for known issues?

Checked pinned issues, Searched open issues, Searched closed issues, Checked the FAQ

AlphaMode commented 1 year ago

Will be fixed next release

AlphaMode commented 1 year ago

Fixed in later versions. A 1.18.2 backport in Porting-Lib will probably be done later.