search

Alpha-s-Stuff / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
86 stars 31 forks source link

[Compat] Inventory Tabs #6

Closed sisby-folk closed 2 years ago

sisby-folk commented 2 years ago

Minecraft Version

1.18.1

Forge Version

Quilt 0.17.1-beta6 (lol)

Mantle Version

N/A

Tinkers' Construct Version

3.5.1.DEV.04887b6

Problem description

When opening a UI such as the part builder or tinker's station, the cursor centers on the window. This is normal behvaviour for vanilla, but with Inventory Tabs it becomes an inconvenience with seemingly an easy fix.

https://user-images.githubusercontent.com/55819817/180699729-f3a1a323-3994-4daa-94f5-2d61e0f14c19.mp4

)

Suggested solution

Don't center the cursor, or, find out why the cursor is being centered in the first place (forcing itself to close and reopen the screen maybe?)

Alternatives considered

Honestly if it's too hardbasket I just wouldn't do it.

Additional context

No response

Searched for existing enhancement?

Used the search bar

sisby-folk commented 2 years ago

This behaviour is of course identical on forge as far as I'm aware, but inventory tabs isn't on forge from what I can tell! If anyone can find an equivalent forge mod that would also cause an issue due to this, feel free to drop the issue upstream.

sisby-folk commented 2 years ago

Lmao I just figured out that tinker's has this "tabbing" behaviour in-built, which is probably what controls this (pictured without inventory tabs) image

Would be good to handle this case and defer to InventoryTabs (disabling tinker's tabs) if possible.

AlphaMode commented 2 years ago

Lmao I just figured out that tinker's has this "tabbing" behaviour in-built, which is probably what controls this (pictured without inventory tabs) image

Would be good to handle this case and defer to InventoryTabs (disabling tinker's tabs) if possible.

I'm pretty sure that would just break tinkers since I'm pretty sure the tabs code is handled on the client and server. I think inventory tabs is all on client. So I see some possible problems there but I'd be glad to accept a pr that adds support though

sisby-folk commented 2 years ago

I think it's handleable - the tab code on the server side doesn't need to change, it's only the physical clickable client-side tabs themselves that need to be hidden from the screen that's being shown, such that they don't overlap with IT's. I'll give it a think at some point.

sisby-folk commented 2 years ago

ahahah yeah I saw the commit - I'll redo the PR no problem - feel free to ditch what we put in

On Tue, 6 Sep 2022, 6:59 am AlphaMode, @.***> wrote:

Reopened #6 https://github.com/Alpha-s-Stuff/TinkersConstruct/issues/6.

— Reply to this email directly, view it on GitHub https://github.com/Alpha-s-Stuff/TinkersConstruct/issues/6#event-7325585007, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANJ34KIQ2JU623SG6PZ6F2TV4ZNKXANCNFSM54Q34ONQ . You are receiving this because you authored the thread.Message ID: @.***>