Alpha-s-Stuff / TinkersConstruct

Tinker a little, build a little, tinker a little more...
MIT License
86 stars 31 forks source link

Fluids don't work properly when attempting to swim in them. #87

Open woodiertexas opened 12 months ago

woodiertexas commented 12 months ago

Minecraft Version

1.20.1

Fabric Version

Fabric 0.14.24 and Quilt 0.21.2

Fabric API Version

FAPI 0.90.7+1.20.1 and QFAPI 7.4.0 + QSL 6.1.2

Hephaestus Version

1.20.1-3.6.3.232

Describe your issue

You walk through fluids as if you're walking on land: image

Vanilla water for comparison: image

Crash Report

No response

Other mods

Fabric Install: image

Quilt Install: image

Tried reproducing with just Tinkers?

Yes

Performance Enchancers

Sodium

Searched for known issues?

Searched open issues

AcidArmy commented 10 months ago

This has been the exact same behavior since at least 1.12.2. I think this is just a feature.

PengyTheGamer commented 10 months ago

i don't think this is a feature, but i think forge 1.18 and 1.16 lacked the proper fluid behaviours so, this is likely just from it being a port of the forge version

jshipley commented 3 months ago

The way most mods handle this now is to add their fluids to the minecraft:fluids/water or minecraft:fluids/lava (minecraft:fluid/water or minecraft:fluid/lava after 1.21) tags. This isn't a perfect solution, but it's enough to get Minecraft to handle the fluid physics and entity interactions.