After reviewing Olivia's pull request, I realized that we were missing 'back buttons' on facultyMap.php and legend.php. This created a wacky interface that required us to use the browser back buttons or restart the web app which is not good for any users.
After reviewing the code I accepted the pull request and went in and added those two buttons into the code myself instead of rejecting the pull request and waiting on Olivia to resubmit her code. This allowed us to use our class time much more productively as we collaborated on this PR and enhanced the web app greatly.
What I did
-Edited and fixed facultyMap.php
-Edited and fixed legend.php
(back to main map button added for visual reference)
(back button added to facultyMap.php for visual reference)
Developer Olivia Hammond sent a code review to me on her PR.
The link to this PR is https://github.com/AlphaAndTheOshea/Parking-App-UNA/pull/43#pullrequestreview-640434276
What Olivia edited
What Olivia added
How we collaborated
After reviewing Olivia's pull request, I realized that we were missing 'back buttons' on facultyMap.php and legend.php. This created a wacky interface that required us to use the browser back buttons or restart the web app which is not good for any users.
After reviewing the code I accepted the pull request and went in and added those two buttons into the code myself instead of rejecting the pull request and waiting on Olivia to resubmit her code. This allowed us to use our class time much more productively as we collaborated on this PR and enhanced the web app greatly.
What I did
-Edited and fixed facultyMap.php -Edited and fixed legend.php