search

AlphaKretin / bastion-bot

A Discord bot for displaying information about Yu-Gi-Oh! cards.
https://www.patreon.com/alphakretinbots
GNU General Public License v3.0
23 stars 16 forks source link

Issues with Reaction Buttons #36

Closed AlphaKretin closed 5 years ago

AlphaKretin commented 5 years ago

The reaction buttons on search menus have a variety of errors, but they are inconsistent enough to make testing difficult.

They work in some servers.
reactions working
But not some others. Googling tells me this error is supposed to mean that Bastion's not in this channel, which is blatantly false.
reactions not working
Also worth noting that reactions are disabled in direct messages, so it would be highly ideal to implement an alternate navigation method also.
reactions in dms

AlphaKretin commented 5 years ago

I have confirmed it's not a permissions issue, which gives me mixed feelings. I now know it's not just something dumb, and it's hopefully something on my end I can fix. On the other hand, I now don't have much of a lead. I plan to ask advice in the Eris support channel, further action is pending a useful response there.

AlphaKretin commented 5 years ago

According to a discussion in the Eris channel (invite link), it seems like it might be Discord's fault. If this is the case, there's nothing I can do until they suddenly fix it one day. I'm going to have to check that periodically. :/ Hopefully it isn't too wide-spread. In the meantime, implementing the .p and .d equivalents for .search and .match is more important than ever.

AlphaKretin commented 5 years ago

Now that I think of it, displaying a card through a match page should probably edit the message instead of posting a new one, the same way as scripting library pages.

AlphaKretin commented 5 years ago

The new commands are added in #43. However, the main issue is still at hand.

AlphaKretin commented 5 years ago

If I can muster the effort to get all the info in one place in a formal report (and the courage to actually do it), I might file an issue about it on the Discord API issue tracker.

AlphaKretin commented 5 years ago

@NaimSantos noticed that in the server with the issue, Bastion was missing the "Read Message History" permission. This explains everything! It does have permission to read the message and react to it, but when it goes to get the message to react to it, it can't read the history, so it can't access it anymore - Missing Access. I need to handle this in the permission check.