Convert Pendulum text detection to regex (partial)

AlphaKretin / ygo-data

A Node module to parse YGOPro card databases and other files into useful card data

GNU General Public License v3.0

11 stars 0 forks source link

Convert Pendulum text detection to regex (partial) #6

Closed AlphaKretin closed 5 years ago

AlphaKretin commented 5 years ago

Fix #7 To better support edge cases and other languages, this converts the Pendulum Text detection from a messy algorithmic approach to regular expressions (based on the ones used by DataEditorX).

AlphaKretin commented 5 years ago

This is not currently ready to merge, as a test is failing. The regular expression for Japanese Monster Text is not matching Odd-Eyes Pendulum Dragon's monster effect in tests, even though as far as I can tell it should. I'll have to revisit this later. https://regex101.com/r/fEXlk0/1

coveralls commented 5 years ago

Pull Request Test Coverage Report for Build 97

14 of 16 (87.5%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-1.5%) to 98.077%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
dist/class/CardText.js	14	16	87.5%
<!--	Total:	14	16	87.5%	-->

Totals
Change from base Build 95:	-1.5%
Covered Lines:	214
Relevant Lines:	216

AlphaKretin / ygo-data

Convert Pendulum text detection to regex (partial) #6

Pull Request Test Coverage Report for Build 97

💛 - Coveralls