AlphaKretin / ygo-data

A Node module to parse YGOPro card databases and other files into useful card data
GNU General Public License v3.0
11 stars 0 forks source link

Improve pendulum text handling #7

Closed AlphaKretin closed 5 years ago

AlphaKretin commented 5 years ago

Bastion's current method for splitting up the text of Pendulum Monsters into 2 sections is flawed. For one, it's a clunky, inelegant algorithm. It also assumes it's laid out in roughly the same format as Percy, which causes compatibility issues with other languages and other use cases.

To my knowledge, DataEditorX uses a Regex-based solution, and I would prefer to do the same. However, I have failed to replicate it in the past, when I knew a lot less about both programming and Regex.

amarillonmc commented 5 years ago

For reference, that's how the Pendulum monsters are rendered in other languages in their cdbs:

Chinese:

←1 【灵摆】 1→
[Pendulum Effects Goes Here]
【怪兽效果】
[Monster Effects Goes Here]

Also Chinese, but outdated:

[Monster Effects Goes Here]
3 魔法卡 3
[Pendulum Effects Goes Here]

Japanese:

【Pスケール:青1/赤1】
[Pendulum Effects Goes here]
Note: They are using full-width numbers for the scale number.
【モンスター効果】
[Monster Effects Goes Here]

Korean:

펜듈럼 효과

[Pendulum Effects Goes here]
Note: Korean cdb does not record the Pendulum Scale within CDB entries

몬스터 효과

[Monster Effects Goes here]

All above refers to official card cdb files only,

AlphaKretin commented 5 years ago

Thanks