search

AlphaWallet / AlphaWallet-web3-provider

[Used in AlphaWallet]
MIT License
58 stars 37 forks source link

eth_signTypeData_v3 hook for EIP712 #12

Closed JamesSmartCell closed 3 years ago

JamesSmartCell commented 4 years ago

Adds the EIP712 signing hook to the AlphaWallet dist.

See article here:

https://medium.com/metamask/eip712-is-coming-what-to-expect-and-how-to-use-it-bb92fd1a7a26

in particular the new hook eth_signTypedData_v3.

I will create a separate issue for iOS with an in-depth 'How-To' for EIP712 and legacy EIP712 (eth_signTypeData), both standards are in use and we should support them.

bitcoinwarrior1 commented 4 years ago

@JamesSmartCell did you change the regular dist file then minify?

JamesSmartCell commented 4 years ago

Yes. Is that how it should be done? Or is there a better process?

bitcoinwarrior1 commented 4 years ago

Yes. Is that how it should be done? Or is there a better process?

That is the right way (technically the builder should work but it doesn't) just wanted to clarify because checking the diff in the min file is very difficult

hboon commented 4 years ago

checking the diff in the min file is very difficult

Understatement of the year :)

hboon commented 3 years ago

Superseded by #14