AlphaWallet / TokenScript-Repo

A repo full of signed TokenScript files which are served to AlphaWallet
7 stars 10 forks source link

a new schema version negotiation method #5

Closed SmartLayer closed 5 years ago

SmartLayer commented 5 years ago
  1. Change namespace for old fifa ticket tokenscripts.
  2. set up a new repo server to repo.tokenscript.org. old repo.aw.app will never update again.
  3. make sure ios/android both recognises namespace and gives update warning if namespace doesn't match (will be filed in a separate issue too)
  4. ios/android change default repo server to repo.tokenscript.org before releasing.
hboon commented 5 years ago

@colourful-land I suppose we'll be including the supported schema version when we make the request?

Update: forgot that server can use iOS/Android versions sent in header to check.

SmartLayer commented 5 years ago

@hboon we started with a simple idea to avoid over-designing in the beginning, but we probably shouldn't be using iOS/Android version anymore more if we activate repo.tokenscript.org since other clients (metamask-based one - to be invented) can't supply those. So we should utilise some kind of content-negotiation in the request.

hboon commented 5 years ago

@colourful-land we should probably still send the headers that we have now for completion (we might want stats etc later), but include the schema version to be used for content-negotiation?

SmartLayer commented 5 years ago

@colourful-land we should probably still send the headers that we have now for completion (we might want stats etc later), but include the schema version to be used for content-negotiation?

Agree. Check this: https://github.com/AlphaWallet/TokenScript-Repo/blob/master/README.md

And follow the link "user-agent behaviour" to see the client spec maintained.