search

AlphaWallet / TokenScript-Repo

A repo full of signed TokenScript files which are served to AlphaWallet
7 stars 10 forks source link

add latest fifa with new schema #7

Closed bitcoinwarrior1 closed 5 years ago

bitcoinwarrior1 commented 5 years ago

For #3

@colourful-land you might wish to sign this with another key?

bitcoinwarrior1 commented 5 years ago

@colourful-land this has been updated again and is ready to merge.

bitcoinwarrior1 commented 5 years ago

@hboon fifa uses binary time, added this amendment and converted to uint

SmartLayer commented 5 years ago

@hboon fifa uses binary time, added this amendment and converted to uint

That's not how I remembered it. FIFA's time is timezone sensitive, e.g. a match at 18.00 doesn't show up as 15.00 if you are in England. If you use BinaryTime, it will show as 15.00 if the user is in England.

The way I remembered it, it is a mapping to GeneralisedTime. The attribute type is the type of data after mapping, not before mapping.

In fact, FIFA is a game that changed our perception of time. We started with Binary Time and hit a rock with FIFA ticket then we introduced GeneralisedTime 𝑏𝑒𝑐𝑎𝑢𝑠𝑒 𝑜𝑓 FIFA.

bitcoinwarrior1 commented 5 years ago

@colourful-land @hboon fixed with generalised time mapping

SmartLayer commented 5 years ago

@James-Sangalli you signed with the wrong key. should use sktravel.cn key. I have the right key (albeit expired) but can you point me to the unsigned XML for me to sign a new version?

bitcoinwarrior1 commented 5 years ago

@James-Sangalli you signed with the wrong key. should use sktravel.cn key. I have the right key (albeit expired) but can you point me to the unsigned XML for me to sign a new version?

https://github.com/AlphaWallet/TokenScript/tree/fifa-DO-NOT-MERGE