EIP-155 implementation - Githubissues

AlphaWallet / Web3E

Web3E Ethereum for Embedded devices running Arduino framework

MIT License

143 stars 45 forks source link

EIP-155 implementation #17

Closed tomasz90 closed 1 year ago

tomasz90 commented 1 year ago

I once again reviewed previous changes and made some refactor to be able to provide EIP-155 to library without breaking anything. Now this implementation only changes signatures to include chain id.

[ v] added constructor to explicit Contract(long long int networkId);, now we dont have to create new web3 obj to send transaction, just provide chainid
[ v] added fn SignTransaction(...) to be able just for signing
[ v] added getter to web3 getChainId() to be able to retrive chainId

JamesSmartCell commented 1 year ago

Awesome work. Let me check and merge

tomasz90 commented 1 year ago

@JamesSmartCell Thanks!

JamesSmartCell commented 1 year ago

@JamesSmartCell Thanks!

Thanks for the PR! I hadn't tried on Sepolia yet, but yeah we definitely needed to support eip155.

tomasz90 commented 1 year ago

I just tested this on sepolia, signing and then broadcasting signed tx is working :)