AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
585 stars 528 forks source link

Update TS Buttons #1149

Closed colourfreak closed 4 years ago

colourfreak commented 4 years ago

Sketch Cloud:

and few more if you switch to next to the right.. (Function 3,4,5,6)

Zeplin: https://app.zeplin.io/project/5d088205bff2d15de6a4397b/dashboard?seid=5e41333605a98088a65653b4

colourfreak commented 4 years ago

Screenshot 2020-02-10 11 45 21

colourfreak commented 4 years ago

@colourful-land wants to outsource this part to new developers on Upwork - and hire the one who provided the highest quality.

JamesSmartCell commented 4 years ago

This doesn't look Android native. The way shown above doesn't appear as a design pattern on Android interfaces.

Instead when pressing the hamburger button potentially extra buttons should appear in a panel; possibly with some sort of priority so the TokenScript developer can supply hints as to how the buttons should appear. We can see what our outsourcers do with this; it's actually a good first issue.

colourfreak commented 4 years ago

https://material.io/components/sheets-bottom/#usage

Check Modal Sheet Bottom. Because TS limitations, we can't support icons. So I removed them.

If you want, we can also remove "More options" from the top.

Screenshot 2020-03-03 13 12 58

https://storage.googleapis.com/spec-host-backup/mio-components%2Fassets%2F1xY0fPveXIEcZrtyPbRtnDDEcn1IOJTch%2Fmodal-usage-overflow.mp4

JamesSmartCell commented 4 years ago

Agree this should be implemented on Android in the modal bottom sheet style. We further discussed the possibility of button weighting or priority in the meeting today. Being able to create a button with higher priority than the intrinsic buttons is also worthwhile.

JamesSmartCell commented 4 years ago

Closed by #1250