AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
603 stars 535 forks source link

complete the migration to `FunctionButtonBar` #1384

Open SmartLayer opened 4 years ago

SmartLayer commented 4 years ago

Currently, on the master (with fiji merged in) the primary colour is white; secondary is #54C1E3

For example, the primary color @colourfreak has chosen seem to be blue, but buttons are still coloured black-and-white in the following

(In fact, I checked that none of these buttons is modified in the Fiji PR #1248 recently merged.

I need @tomekalphawallet to supply the correct values so this can be assigned to someone.

JamesSmartCell commented 4 years ago

Any bottom button should have been replaced by the generic 'FunctionButtonBar'. This is so if there is any style or colour change it can be effected in one move. There may be a few old classes that haven't been migrated to use this portable view class.

SmartLayer commented 4 years ago

A bit of comments copied from design guide for anyone who @AW-STJ wants to assign this to

our design is very minimalistic, lot of white spaces. We use "Azure" #007fed as a primary color for segmented controls, links, tab bar active icon, illustrations etc. Then we have #75b943 "Green" which is used for buttons and illustrations. White is not considered as a color (I know how it souds), becuase is used as a backgroud (thoughout 90% websites and apps).

https://zpl.io/anE1dPn - you can access Master Library with colors, components, styles

JamesSmartCell commented 4 years ago

NB the list at the top of this page is now very outdated: it appears to be based on a pre-Fiji build. Need to produce a new list. All the instances of the old button are all on the ERC875 flow; so the importance of this modification is somewhat reduced.

ERC875 Redeem is the only screen I could find the old style.