search

AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
584 stars 528 forks source link

EIP1155 display support #1778

Open JamesSmartCell opened 3 years ago

JamesSmartCell commented 3 years ago

EIP1155 supports a collection of tokens, fungible, "semi-fungible" and non-fungible.

EG:

1 Ring to rule them all 3 Rings for Elves 7 Rings for Dwarfs 1,000,000 Gold coins 20,000,000,000 Sestertii

These would all be operating from the same contract. Each one can be associated with a graphic asset embedded within the contract.

How to support this in the wallet?

It could be similar to how we group transactions. So, all the tokens within the EIP1155 contract could be listed together in order, and there would be some kind of graphic to indicate they are all part of the same contract.

So far, the only wallet we know for sure supports EIP1155 is Engin wallet (it's their standard). It might be worth checking out how they display it.

For now, it would be good to have at least limited support to show EIP1155 tokens; they look to have a growing part to play, especially for games. The key thing is they support fully atomic DvP between tokens; you could sell the 1 Ring for however many gold tokens in the same transaction without needing 'approve' and helper contracts.

colourfreak commented 3 years ago

Ideally, I would need to get some examples of those tokens. Where to look for and not get bankrupt at the same time? Open Sea?

JamesSmartCell commented 3 years ago

I don't know if they're on opensea. And, I don't know how to get any.

I can create a contract and mint some, but it won't help because we don't have any way to display until the code is written.

We are pioneers here. The only implementation would be in Engin, but I don't know how they display them.

The key facts are: Many tokens which are related, do we need to show a relationship between them? It's beneficial because then people know the gas fee is low to trade between them.

Maybe I need to make an implementation like with grouped transactions before anyone gets what I'm talking about.

colourfreak commented 3 years ago

erc1155-large

hboon commented 3 years ago

@justindg @JamesSmartCell Have we figured out how to get ERC1155 token transactions via Etherscan or Blockscout?

I couldn't find the transaction https://ropsten.etherscan.io/tx/0xfc924192fb068a6326bc28a2f5762be3a4b1fb6a1ef801bf6bf02c06af929d53 [1] in Etherscan API output:

$ curl 'https://api-ropsten.etherscan.io/api?module=account&action=tokentx&address=0xB0A6237D376B71AE1E480A8c728239ED663Fa941&startblock=3501477&endblock=3501478'

{"status":"0","message":"No transactions found","result":[]}

[1] https://github.com/ethereum/EIPs/issues/1155#issuecomment-399800676