AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
585 stars 529 forks source link

Investigate: App unresponsive while resuming Dapp browser session after keeping the app in background for some time #2081

Open AW-STJ opened 2 years ago

AW-STJ commented 2 years ago

User feedback: After using other apps, coming back to AlphaWallet Dapp browser goes to this state below. The app requires a restart.

image

For this particular instance, the user was on Polygon prior to switching the app to background. Once resuming the session on AlphaWallet, the network changed to 'Eth' and no icon. This requires app restart. Happens often (1-2 times a day).

Also this issue had been existing across different wallet versions.

AW-STJ commented 2 years ago

@hieronymus4826 can you investigate and confirm this issue can be replicated.

hieronymus4826 commented 2 years ago

I tried both phones, for unlimited times. The browser session stays the same for me. I tried waiting for up to 6 hours, closing the app completely, changing the internet connection, rejoining the old connection, opening multiple apps and wallets. The dapps stay open, connected to the same network and on the same page I left.

AW-STJ commented 2 years ago

Thanks @hieronymus4826 .

Can you check with the Discord user Roguetr under #dapp-chat channel?

JamesSmartCell commented 2 years ago

It sounds like it could be a memory leak issue. I have fixed a few memory leaks associated with the DappBrowser, these went out in the 3.40.1 release. There is still one more remaining but that only manifests when you use signing or sending transactions from DappBrowser. This one is slightly harder to fix as it requires a refactor of one of the background services.

hieronymus4826 commented 2 years ago

I will check if it happens when I interact with an app and then leave it open, so far I have just tested it by leaving it open.

JamesSmartCell commented 2 years ago

This may have been fixed by #2201

hieronymus4826 commented 2 years ago

I have tried many times over the month and could never reproduce

JamesSmartCell commented 2 years ago

I could reproduce something like it by using Alchemy, Twitter tipper, 1Inch and Uniswap then going into the dappbrowser and with an empty URL scroll down the list for a bit ... it locks up sometimes. This is now fixed.