search

AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
596 stars 530 forks source link

Unstoppable Domains name resolution deprecation/changes #2364

Closed oa-s closed 2 years ago

oa-s commented 2 years ago

There are some changes to name resolution or deprecation.

This:

We wanted to share an update regarding changes we are making to our API integration (https://unstoppabledomains.com/api/v1/). We will be deprecating this API next year in favor of resolution services hosted by our partners: Alchemy and Polygon. We will share details of these resolution services soon.

and this:

Also, we are dropping support for ENS domain name resolution from our API on Dec 31st. If you have been using our APIs for ENS name resolution, we recommend you integrate with ENS directly by following their guide: https://docs.ens.domains/dapp-developer-guide/resolving-names

There's also a separate integration doc. Will send you the link privately.

Would you help to check them, summarize what we need to do? And if it's obvious it needs to be done and simple enough, would you make the change?

Follow https://docs.alchemy.com/alchemy/enhanced-apis/unstoppable-domains-apis tutorial for implementation of Get records for owner addresses and Get records for a domain.

hboon commented 2 years ago

@oa-s can you help assign to James when you are done writing up?

JamesSmartCell commented 2 years ago

Will send you the link privately.

Can you resend this?

asif-finimble commented 2 years ago

@JamesSmartCell can you guide me on this as what needs to be done. I cant find usage of unstoppable domains api. AWEnsResolver is resolving using ens.

hboon commented 2 years ago

@JamesSmartCell bump

JamesSmartCell commented 2 years ago

@hboon @oa-s we don't use unstoppable domains on Android, could you explain what it is and how it's different from ENS?

We use 3 name resolution services - ENS directly from chain, DAS (.bit) and the .crypto domains.

From reading the docs my assumption is that 'unstoppable domains' is an aggregator that resolves all the various crypto domains. Is this correct?

JamesSmartCell commented 2 years ago

Do we need an API key to query the Alchemy domain aggregator API? If indeed it is that.

hboon commented 2 years ago

Hmm.. I always thought Android supported Unstoppable domains first. In that case lowering priority since it's not going to cause problems. What we do in iOS is to go with ENS first and then fallback to Unstoppable. Name resolution could be an attack surface so we should try to keep the 2 resolutions separate and if need be disable one (or all of them).

Do we need an API key to query the Alchemy domain aggregator API? If indeed it is that.

Yes we do.

Build a list of questions and buzz @oa-s?

hboon commented 2 years ago

Refer to #2929