search

AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
583 stars 527 forks source link

How to change the image and app name in the third party sites like rarible.com #2837

Open GowthamParamasivam opened 1 year ago

GowthamParamasivam commented 1 year ago

I would like to change the logo and app name in the third party sites after connecting to their site. When i clone the repo and customize the wallet code and connect in the 3rd party site, it still shows the alphawallet icon and name.

alphawallet

seabornlee commented 1 year ago

Hi, you can search initWalletConnectPeerMeta in WalletConnectActivity.java, and change the WCPeerMeta construction params.

GowthamParamasivam commented 1 year ago

Hi @seabornlee,

tried changing what you said, but still I could not see the change. I changed the params mentioned in this line.

Am I missing something here?

alphawallet-issue2

seabornlee commented 1 year ago

Sorry, I found there is another place https://github.com/AlphaWallet/alpha-wallet-android/blob/2896aedfd5cf66dca5b5d323b1f9b1f48f95b574/app/src/main/java/com/alphawallet/app/walletconnect/entity/WCUtils.java#L37 Will remove this duplication.

GowthamParamasivam commented 1 year ago

Hi @seabornlee, Changed in both the places but still i dont see any changes on the 3rd party sites, still it shows the logo and name as alpha wallet.

hboon commented 1 year ago

Is this in the dapp browser and not through WalletConnect? If so, try exploring along this line too:

It could be because rarible.com is checking the isAlphaWallet flag against the provider we inject.

If so, we do this in the web3 provider (note that this is not in the AlphaWallet app repository) https://github.com/AlphaWallet/AlphaWallet-web3-provider/blob/9a4496d02b7ddb2f6307fd0510d8d7c9fcef9870/src/index.js#L51. I think AlphaWallet Android might be bundling this file directly so maybe isAlphaWallet = true is the bit to look for. You can verify by resetting it to false and see if that option goes away in rarible.com. If it does, unfortunately, it might be a hassle to get dapps to recognize is<my wallet name>.