AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
596 stars 530 forks source link

Add OKEx chain which is an evm chain #3030

Closed Mantisrei closed 1 year ago

Mantisrei commented 1 year ago

i want to add okex chain but after making changes, home screen is blank and app keeps crashing

JamesSmartCell commented 1 year ago

How are you adding it?

See this commit, and duplicate:

https://github.com/AlphaWallet/alpha-wallet-android/commit/44df65f7d864bd57222758dafa9c04b0fc2b5c07

Mantisrei commented 1 year ago

I want to add it to the main code and later display it in the custom view.

JamesSmartCell commented 1 year ago

Yes, just following the 44df65f commit (just change the Ids and find the OKX API calls) will allow you to do that. If you try to do it in a different way it'll probably crash - as you found out.

JamesSmartCell commented 1 year ago

Hi @Mantisrei did you get anywhere with this one? In particular did you find:

JamesSmartCell commented 1 year ago

@Mantisrei I looked into it, but couldn't find any Etherscan/Blockscout API. There is a custom API - oklink - but this provides a different style of query. Were you able to find anything better?

I found these instructions which give a very basic interface, but not a good experience as it won't discover an NFT/Tokens etc.

https://decentralizedcreator.com/add-okt-to-metamask/

JamesSmartCell commented 1 year ago

Ok I have got the API routes from the OKX team.

JamesSmartCell commented 1 year ago

Closing as we are handling this internally.

@Mantisrei it'll be in a release which will be out later this month.