search

AlphaWallet / alpha-wallet-android

An advanced Ethereum mobile wallet
https://www.alphawallet.com
MIT License
602 stars 535 forks source link

Splash screen is dim #3319

Closed tab00 closed 1 year ago

tab00 commented 1 year ago

The startup splash screen appears dim, as if it has a semi-transparent dark overlay. How can we make it appear without a dark overlay?

tab00 commented 1 year ago

@JamesSmartCell where in the code can the dark overlay be removed?

JamesSmartCell commented 1 year ago

@JamesSmartCell where in the code can the dark overlay be removed?

https://github.com/AlphaWallet/alpha-wallet-android/blob/master/app/src/main/res/drawable/background_splash.xml

I don't know why it appears dim you could try changing the colours in the xml

tab00 commented 1 year ago

I've found the cause. If you enable Dark Mode in Android settings then there will be a dark overlay: splash-screen-lime-dark-mode

If you disable Dark Mode then there'll be no dark overlay: splash-screen-lime-light-mode

So how can we have the dark overlay disabled regardless of lightness mode? Would it be possible to force light mode in the app just during the splash screen so that the dark overlay will never appear?

JamesSmartCell commented 1 year ago

I've found the cause. If you enable Dark Mode in Android settings then there will be a dark overlay: splash-screen-lime-dark-mode

If you disable Dark Mode then there'll be no dark overlay: splash-screen-lime-light-mode

So how can we have the dark overlay disabled regardless of lightness mode? Would it be possible to force light mode in the app just during the splash screen so that the dark overlay will never appear?

sounds like an Android rabbithole to spend a long time searching for a solution! If you find a way please let me know.

You can't just remove the overlay in the vector splash? Or brighten the colours in the logo a little?

tab00 commented 1 year ago

You can't just remove the overlay in the vector splash?

Where is the overlay?

Is it the app somehow placing the overlay if it detects that Android is in dark mode, or is the OS doing that?

JamesSmartCell commented 1 year ago

It could be happening in the theme setup.

JamesSmartCell commented 1 year ago

Hi @tab00 fixed in this PR: #3332

With one proviso: The phone has to be in dark mode, then the correct dark mode splash will display. If the user's phone is in light mode and the wallet set to dark mode, the light mode splash will show.

tab00 commented 1 year ago

Thanks @JamesSmartCell . So it's now using the new Splash Screens API, which is good. Though it doesn't seem to allow customizations like gradient or image background, or a fullscreen foreground image.