search

AlphaWallet / alpha-wallet-ios

An advanced Ethereum/EVM mobile wallet
https://www.alphawallet.com
MIT License
597 stars 370 forks source link

Update QR scanner screen #1814

Closed hboon closed 4 years ago

hboon commented 4 years ago

We currently use a fork (see Podfile) of QRCodeReaderViewController. Can you either modify it or implement it so that it looks like this? It's fine (probably best) if you can remove the dependency on QRCodeReaderViewController if implementing the scanner from scratch works for you:

https://app.zeplin.io/project/5d0356be2f25b319dcc5944b/screen/5e54e153f1689c658669eb8a

It's probably used in a few places.

Out of scope

You can ignore the "My QR code" button for now.

Boon for later:

Related: #1738

colourfreak commented 4 years ago

Not sure if that matters, but in the future, we might add an ability to trigger this screen with Siri. Having that in the back of mind might be good at this stage.

hboon commented 4 years ago

Yes, likely from the app launch shortcuts too

vladyslav-iosdev commented 4 years ago

@hboon Hi, i sent PR https://github.com/AlphaWallet/QRCodeReaderViewController/pull/1 can't find how to set you as reviewer.

hboon commented 4 years ago

@vladyslav-iosdev Just added you as a collaborator. Could be the reason. Do you see this?

Screenshot 2020-05-22 at 3 24 22 PM
vladyslav-iosdev commented 4 years ago

no, there is no settings button

Screenshot 2020-05-22 at 10 30 23
hboon commented 4 years ago

@vladyslav-iosdev no idea why. It's alright. You can just buzz me to review in a PR if you can't assign me :)

vladyslav-iosdev commented 4 years ago

@hboon QRCodeReaderViewController called from several places manually, do i need to replace those calls with calling it through ScanQRCodeCoordinator?

hboon commented 4 years ago

@vladyslav-iosdev yes, that would be great. Is it independent of this issue? If it is, create a new issue "Refactor all access to QRCodeReaderViewController so it goes through ScanQRCodeCoordinator" and assign yourself.

vladyslav-iosdev commented 4 years ago

yes, that would be great. Is it independent of this issue? If it is, create a new issue "Refactor all access to QRCodeReaderViewController so it goes through ScanQRCodeCoordinator" and assign yourself.

yes it is. ok.

hboon commented 4 years ago

Closed by https://github.com/AlphaWallet/QRCodeReaderViewController/pull/1