AlphaWallet / alpha-wallet-ios

An advanced Ethereum/EVM mobile wallet
https://www.alphawallet.com
MIT License
598 stars 372 forks source link

Include network name in Activity tab? #2339

Open hboon opened 3 years ago

hboon commented 3 years ago

From Sunil in https://github.com/AlphaWallet/alpha-wallet-ios/issues/2293#issue-746194844 :

  1. Activity needs network as in Android, otherwise Rinkby and Mainnet transactions looks the same image

@AW-STJ I checked with @colourfreak when I implemented that and one of the constraints were that there isn't enough space/breathing room for more information. But if it's important, and we can tweak it and make it work, we can implement it.

colourfreak commented 3 years ago

I have many ideas and suggestions about Activities (even though I believe this is one of the most developed part of AlphaWallet).

  1. Network name could go on the left side of a date, aligned to the right.
Screenshot 2021-03-19 at 09 17 52
  1. Another issue, I think having just 3 states for transactions would be better. Arrows pointing to the top right and arrows pointing down are too similar to each other. Maybe it's better to make it even simpler.

Now we have:

Screenshot 2021-03-19 at 09 30 49

Maybe instead:

Screenshot 2021-03-19 at 09 30 12
  1. We have a lot of unused real estate if you open any Activity. I know it has some long-term ideas, but I have never seen this applied.
Screenshot 2021-03-19 at 09 18 04

it does make sense to keep it in the current format, only if we plan to develop activities in this way:

Screenshot 2021-03-19 at 09 19 32 Screenshot 2021-03-19 at 09 19 50 Screenshot 2021-03-19 at 09 18 38

but for now, for all send/receive transactions we have unused real estate. And there is nothing new you can learn if you open a certain activity.

hboon commented 3 years ago

@colourfreak regarding networks, what do you think about https://trello.com/c/5N7J6mjY/21-explicit-and-mutually-exclusive-test-vs-prod-mode?