Open hboon opened 2 years ago
First usage: A network icon in a corner of each token
So we have this small network icon in the bottom left corner of each token.
It's 16x16.
This is an example:
And this is our goal:
Network icons: https://zpl.io/agE1LeZ
Second usage The token symbol is only uploaded once and reused if there is the same token on a different network.
That means that I can remove all uploads from iconassets that were related to BSC, Polygon, Heco, etc. and upload only one token icon without any network icon in a corner (Mainnet Ethereum).
@JamesSmartCell umbrella issue
@hboon Can you go ahead and make an order with current iconsets? Let's chat about it on Discord.
Sure, let's chat. But what do you mean by "make an order with current iconsets" ?
Sure, let's chat. But what do you mean by "make an order with current iconsets" ?
So currently all BSC, Heco, Polygon tokens uploaded to iconassets (sorry, missed this with iconsets) have this small network icon already there. It might look weird sometimes if we have this network icon inside a graphical file and as another layer.
@colourfreak ok. Let me think a bit about what’s the easiest way to do this. Will get back to you tomorrow. Feel free to update the icons locally first, but don’t upload yet.
Here's how I suggest we do it.
Tomek:
Boon:
iconassets
repo based on the updated zipBoon and James
iconsassets
repo and those embedded in the appI had thought to do this in a proper way because doing it like above will result in a window between 5 and 7 where the icons from iconassets don't have their chain overlay, but I think it's too slow and we are dragging it out, so let's just get it done.
How does that sound @colourfreak?
Sounds good. I am on it. @hboon
@colourfreak sorry, one more (on mobile). The little chain icons to bundle with the app. Not sure we already have them in the app.
Network icons: https://zpl.io/agE1LeZ
This one?
This one?
@colourfreak yes. Thanks.
@hboon
@colourfreak got it. Thanks!
iconassets
for mapped tokensiconassets
(is this only for those that are in token maps or every token in Wallet tab?) #3542 https://github.com/AlphaWallet/alpha-wallet-android/issues/2294iconassets
to remove chain icon overlay from every icon that has them #3545master
oficonassets
again as described in https://github.com/AlphaWallet/alpha-wallet-ios/pull/3627#issue-812919069More: