AlphaWallet / alpha-wallet-ios

An advanced Ethereum/EVM mobile wallet
https://www.alphawallet.com
MIT License
598 stars 373 forks source link

Swaps not working on SushiSwap (approval does) #4036

Open Hoanib opened 2 years ago

Hoanib commented 2 years ago

Although the approval for move the USDC was broadcasted and confirmed, it wasn't the swapping every time I tried.

AW-STJ commented 2 years ago

Hey @Hoanib - thanks so much for logging issues.

When you do that can you share the version of the app as well as steps to reproduce the issue?

Screenshots would also be helpful

Hoanib commented 2 years ago

Hey @Hoanib - thanks so much for logging issues.

When you do that can you share the version of the app as well as steps to reproduce the issue?

Screenshots would also be helpful

iOS version 3.36 (419)

Yea I have screenshots taken where can I post them? Sorry it's my first time in GitHub.

hboon commented 2 years ago

Sorry it's my first time in GitHub.

We appreciate your contribution, bear with us :) —

Example of step by step reproduction:

https://github.com/AlphaWallet/alpha-wallet-ios/issues/3887#issuecomment-1034554835

Example with screenshot (sometimes both steps to reproduce and screenshots are useful):

https://github.com/AlphaWallet/alpha-wallet-ios/issues/3998

If it makes it more obvious, feel free to annotate the screenshot:

https://github.com/AlphaWallet/alpha-wallet-ios/issues/3948

On desktop:

You can drag and drop the screenshot image files into GitHub comment box and it will upload for you.

On mobile:

There's this attach button:

Hoanib commented 2 years ago

image

Hoanib commented 2 years ago

image

Hoanib commented 2 years ago

image

Hoanib commented 2 years ago

image

Hoanib commented 2 years ago

And finally the Tx view in explorer:

https://etherscan.io/enslookup-search?search=https://etherscan.io/tx/0x274a97cb8ce873f7a0cfc2e2c117d1be90d5ea8642

Hoanib commented 2 years ago

Thank you so much for guiding me.

On Mon, Mar 7, 2022 at 02:36 Hwee-Boon Yar @.***> wrote:

Sorry it's my first time in GitHub.

We appreciate your contribution, bear with us :) —

Example of step by step reproduction:

3887 (comment)

https://github.com/AlphaWallet/alpha-wallet-ios/issues/3887#issuecomment-1034554835

Example with screenshot (sometimes both steps to reproduce and screenshots are useful):

3998 https://github.com/AlphaWallet/alpha-wallet-ios/issues/3998

If it makes it more obvious, feel free to annotate the screenshot:

3948 https://github.com/AlphaWallet/alpha-wallet-ios/issues/3948

On desktop:

You can drag and drop the screenshot image files into GitHub comment box and it will upload for you.

On mobile:

There's this attach button:

https://user-images.githubusercontent.com/56189/156987508-18c8d37b-118c-4fb6-ab49-025cc8e62190.jpeg

— Reply to this email directly, view it on GitHub https://github.com/AlphaWallet/alpha-wallet-ios/issues/4036#issuecomment-1060275160, or unsubscribe https://github.com/notifications/unsubscribe-auth/AYBLZ473JTMOQGMLSUVMDDTU6WWWPANCNFSM5QCJPRMA . You are receiving this because you were mentioned.Message ID: @.***>

hboon commented 2 years ago

@Hoanib I'll try to reproduce. But how/where you get this URL:

https://etherscan.io/enslookup-search?search=https://etherscan.io/tx/0x274a97cb8ce873f7a0cfc2e2c117d1be90d5ea8642

or the hex string? 0x274a97cb8ce873f7a0cfc2e2c117d1be90d5ea8642

It's too short for a transaction hash/ID and too long for a wallet

Hoanib commented 2 years ago

When I clicked on View on Explorer, the last screenshot posted, the submitted transaction. https://etherscan.io/tx/0x274a97cb8ce873f7a0cfc2e2c117d1be90d5ea8642020f17eac4ab44af762e8c

Hoanib commented 2 years ago

Now I see that I did not copy it completed. There are other transactions as well: https://etherscan.io/tx/0xba34227df15cdb92f9f6a96c43efba52ba8b001d8983d30628e9d8c0c4eca155

https://etherscan.io/tx/0x57d287ebabc480cd413f12e59f0e9ffc10f9c82a0b474d8f40d30ab5ade433f1

All failed, every time I tried

hboon commented 2 years ago

That helps. Thanks, @Hoanib.

Hoanib commented 2 years ago

That helps. Thanks, @Hoanib.

You are welcome @hboon

hboon commented 2 years ago

I'm stuck with Sushi. I was trying to replicate the issue, but because I tried earlier, now when I try to replicate it again when I tap the Swap button, it prompts me to sign a message (not the swap transaction yet), and after signing, it just says "Transaction Submitted" right away.

i.e. the expected flow should be:

  1. Tap Swap
  2. Tap Confirm Swap
  3. Prompted to sign message
  4. Proceed to sign
  5. Prompted to sign transaction

but observed:

  1. Tap Swap
  2. Tap Confirm Swap
  3. Shown "Transaction Submitted"

@Hoanib do you know how to get out of this? I tried to clear the pending transactions shown in this screenshot and it didn't help:

Screenshot 2022-03-07 at 5 00 35 PM Screenshot 2022-03-07 at 5 27 02 PM
Hoanib commented 2 years ago

@hboon When that kind of things happen to me I do hard refresh clean browser cache and if it doesn't work I do rebooting (turn off and turn on my iPhone).

Very rare indeed

Hoanib commented 2 years ago

I just tried again but without signing the transaction and the output is the expected:

  1. Tap Swap
  2. Tap Confirm Swap
  3. Prompted to sign Signature Request

image

image

image

Hoanib commented 2 years ago

Another thing, @hboon, to consider is to try to swap another token. Sadly I can't do it right now. Trying to figure out all this I want to mention that when I imported the CVX token to SushiSwap I checked in my favourite contract addresses back up and it was the right one.