AlphaWallet / alpha-wallet-ios

An advanced Ethereum/EVM mobile wallet
https://www.alphawallet.com
MIT License
598 stars 373 forks source link

The App Is Not Showing the Balance in USD of the Synthetic Tokens and the Boba Token #4580

Closed Hoanib closed 2 years ago

Hoanib commented 2 years ago

These synthetic tokens are the ones we use to implement cross chain swaps and AW is not registering them well. The balances in USD are not shown. Also the value on dollars of the native token of the Boba blockchain is not shown.

image

oa-s commented 2 years ago

@Hoanib please share a wallet address for watching (for checking)

hboon commented 2 years ago

@oa-s maybe have to use tokens.json

Hoanib commented 2 years ago

0xF2E8F55cc2fd97D44FD0f32040F081F0d2efE5F9

oa-s commented 2 years ago

@Hoanib do you know if these tokens supports by CoinGecko api?

Hoanib commented 2 years ago

@Hoanib do you know if these tokens supports by CoinGecko api?

Boba yes, I don't know about others but I will check image

Hoanib commented 2 years ago

CVXCRV appears on CoinGecko

0x62b9c7356a2dc64a1969e19c23e4f579f9810aa7

image

Hoanib commented 2 years ago

This dApp registers all DeFi tokens, also the total balance of the wallet by chain/of all chains.

https://debank.com/

oa-s commented 2 years ago

Made AlphaWalletRemoteTickerIdsFetcher to use searching in tokens.json, but without impl for now, as not quite realize its logic.

we got let tickerIdsFetcher: TickerIdsFetcherImpl tickerids fetching that is able to search for ticker id in sub providers, eg. InMemory, InListOfDefaultCoinGeckoTickerIds, and in Tokens.json. it has method func tickerId(for token: TokenMappedToTicker) -> AnyPublisher<TickerId?, Never> { that returns first ticker id found in any of added sub providers.

oa-s commented 2 years ago

Boba network isn't supported by AlphaWallet by default, so we don't handle case for this chain

hboon commented 2 years ago

Made AlphaWalletRemoteTickerIdsFetcher to use searching in tokens.json, but without impl for now, as not quite realize its logic.

we got let tickerIdsFetcher: TickerIdsFetcherImpl tickerids fetching that is able to search for ticker id in sub providers, eg. InMemory, InListOfDefaultCoinGeckoTickerIds, and in Tokens.json. it has method func tickerId(for token: TokenMappedToTicker) -> AnyPublisher<TickerId?, Never> { that returns first ticker id found in any of added sub providers.

Buzz me if you want help or clarification

oa-s commented 2 years ago

looks like i am in finish line with it, testing and pushing