search

AlphaZeroIncubator / AlphaZero

Our implementation of AlphaZero for simple games such as Tic-Tac-Toe and Connect4.
0 stars 0 forks source link

Initial NN Architecture, WIP #23

Closed abhon closed 4 years ago

abhon commented 4 years ago

Began working on the NN architecture, have a few things I want to sort out but any feedback appreciated. Not ready for merge.

guidopetri commented 4 years ago

I'm on Python 3.6. Can we fix to that one instead?

On Thu, Jun 11, 2020, 9:17 PM abhon notifications@github.com wrote:

Began working on the NN architecture, have a few things I want to sort out but any feedback appreciated. Not ready for merge.

You can view, comment on, or merge this pull request online at:

https://github.com/AlphaZeroIncubator/AlphaZero/pull/23 Commit Summary

  • create model.py, add python 3.7 to precommit config

File Changes

Patch Links:

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/AlphaZeroIncubator/AlphaZero/pull/23, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOFNOUVBMEIYK4T43WQFNLRWGF2ZANCNFSM4N35Q7UA .

abhon commented 4 years ago

Is there anyway we could do both? When it was 3.6 it would just fail since my computer is using 3.7

guidopetri commented 4 years ago

Are you using something specific to 3.7 that we need it?

On Thu, Jun 11, 2020, 10:16 PM abhon notifications@github.com wrote:

Is there anyway we could do both? When it was 3.6 it would just fail since my computer is using 3.7

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AlphaZeroIncubator/AlphaZero/pull/23#issuecomment-643041794, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEOFNOUZ3S2HKW33XIW4QODRWGM2FANCNFSM4N35Q7UA .

abhon commented 4 years ago

Not really, my computer only has 3.7 on it at the moment. I can redownload 3.6

guidopetri commented 4 years ago

I think you can just install the precommit hook and then modify it back to 3.6 then. I don't think precommit complains.

abhon commented 4 years ago

I've finished the architecture, haven't written a testing script for it yet. However, I'm pretty sure it works(tried things on jupyterlab). I need to just integrate the game class in the tests, which I will do later today.

abhon commented 4 years ago

I'll make the combined nn.module tomorrow. Resolved the issues you mentioned yesterday.

PhilipEkfeldt commented 4 years ago

I think it looks good now, will have more comments when I'll be testing it with my implementation

PhilipEkfeldt commented 4 years ago

Should we merge this? Kinda need this to do my mcts part properly

abhon commented 4 years ago

If Sid wants to merge it first, I'm alright with that - I can always start another branch to write the other nn.module. Apologies for not writing it yet, was on the road with family yesterday, trying to catch up with things today.

guidopetri commented 4 years ago

Looks good, only have a question about the comment I just posted. Will you examine this later? I'll go ahead and rebase/merge.