search

Alsatian67 / FormBundle

Bunch of FormTypes extending some basic Symfony PHP framework FormTypes. ExtensibleTypes makes it possible to allow extra choices by Symfony ChoiceTypes (ChoiceType, EntityType and DocumentType). This can help to make it work with the Select2 jQuery pluggin.
MIT License
14 stars 6 forks source link

Deprecation notices #33

Closed BenoitDuffez closed 1 year ago

BenoitDuffez commented 1 year ago

I'm using Symfony 6.3 and it seems to have triggered quite a few deprecation notices on this lib:

1x: Method "Symfony\Component\DependencyInjection\Extension\ExtensionInterface::load()" might add "void" as a native return type declaration in the future. Do the same in implementation "Alsatian\FormBundle\DependencyInjection\AlsatianFormExtension" now to avoid errors or add an explicit @return annotation to suppress this message.
1x in XXXX:xx from XXX\YYY\Zzz
1x: Method "Symfony\Component\Form\AbstractTypeExtension::buildForm()" might add "void" as a native return type declaration in the future. Do the same in child class "Alsatian\FormBundle\Form\Extensions\ExtensibleExtension" now to avoid errors or add an explicit @return annotation to suppress this message.
1x in XXXX:xx from XXX\YYY\Zzz
1x: Method "Symfony\Component\Form\AbstractType::configureOptions()" might add "void" as a native return type declaration in the future. Do the same in child class "Alsatian\FormBundle\Form\AbstractRoutableType" now to avoid errors or add an explicit @return annotation to suppress this message.
1x in XXXX:xx from XXX\YYY\Zzz
1x: Method "Symfony\Component\Form\AbstractType::configureOptions()" might add "void" as a native return type declaration in the future. Do the same in child class "Alsatian\FormBundle\Form\AbstractExtensibleChoicesType" now to avoid errors or add an explicit @return annotation to suppress this message.
1x in XXXX:xx from XXX\YYY\Zzz
1x: Method "Symfony\Component\Form\AbstractType::configureOptions()" might add "void" as a native return type declaration in the future. Do the same in child class "Alsatian\FormBundle\Form\DatePickerType" now to avoid errors or add an explicit @return annotation to suppress this message.
1x in XXXX:xx from XXX\YYY\Zzz
1x: Method "Symfony\Component\Form\AbstractType::configureOptions()" might add "void" as a native return type declaration in the future. Do the same in child class "Alsatian\FormBundle\Form\DateTimePickerType" now to avoid errors or add an explicit @return annotation to suppress this message.
1x in XXXX:xx from XXX\YYY\Zz

I think it could be as easy as adding void as the return type of load() in here? https://github.com/Alsatian67/FormBundle/blob/master/DependencyInjection/AlsatianFormExtension.php#L13

Alsatian67 commented 1 year ago

Fixed with https://github.com/Alsatian67/FormBundle/pull/34 Thank you for reporting this issue.