Alshie / does-it-flip

Data file for https://www.doesitflip.com/
MIT License
2 stars 3 forks source link

Standardise on all caps or not in certain games and studios #20

Open silverhook opened 4 years ago

silverhook commented 4 years ago

I notices some collections (e.g. Arcade Archives) have the game names in all caps. Do we want to continue changing those to normal case?

Same question regarding the names of some game studions (e.g. HAMSTER, DEGICA).

If so, some PRs I have opened need to be fixed before being merged.

Alshie commented 4 years ago

I can handle this in the code that builds the actual site - I think the caps ones are ones I initially scraped the data for from Nintendo - they have weird capitalisation.

I have set the site to change them all to title case on build.

silverhook commented 4 years ago

That’s an option. But I’m sure some publishers actually are all caps, while others aren’t.

Alshie commented 4 years ago

You're right, and some (eastasiasoft) are all lower- have reverted.

I've corrected a few just now and will check the rest.

I'm looking and Arcade Archives seems to be all caps as a stylistic choice on some titles but not all e.g. 'SUPER PUNCH OUT' vs 'Bells & Whistles' so I think I will correct the ones that are currently lowercased that the eShop has uppercase - I feel we should use what the dev/publisher uses where possible. Would you agree?

silverhook commented 4 years ago

I suspect (at least) part of the problem might be two-fold:

In any case that just may explain why it happened, not that we should continue that way ;)

I agree that it would make sense to default to what the dev/publisher wrote, yes.