Alshweiki / android-vnc-viewer

Automatically exported from code.google.com/p/android-vnc-viewer
1 stars 0 forks source link

Connection to OSX screen sharing does not work #19

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Try to connect to an osx box with screensharing enabled (screen sharing of
osx is just a special vnc server).

the problem is the default colormodel. the osx server seems to have
problems with the C64 colormodel. 

i have attached a patch that contains the following changes:
- added the possibility to change the default colormodel in the connect dialog
- changed the layout of the connect dialog (because i did not want to
hassel with the x and y coordinates)
- added some experimental code to show a cross representing the mousecursor
on the client (i use xor mode, but unfortunately i did not get all updates
to the bitmaps, so depending on the bitmapupdates the crosshair produces
strange artifacts).

Original issue reported on code.google.com by christian.koestlin on 12 Jan 2009 at 7:55

Attachments:

GoogleCodeExporter commented 8 years ago
I'll see about incorporating the patch

Original comment by googlec...@antlersoft.com on 14 Jan 2009 at 4:21

GoogleCodeExporter commented 8 years ago
In future, don't remove @Override from interface implementations in patches :)
(Accepted by a jdk 1.6 compiler)

Also, I'm not sure why we would want to highlight the cursor separately from the
server showing the cursor?  There's no local cursor in android.  Why do you 
need this?

Original comment by googlec...@antlersoft.com on 14 Jan 2009 at 6:08

GoogleCodeExporter commented 8 years ago
sorry, for the removal of the @overrides ... i was not aware that this is legal 
in
java 1.6 (have only 1.5 on the osx box here). 

the osx vnc-server does not show the mousecursor by default (perhaps it can be
activated, so i tought i wold give it a try). but feel free, to remove these 
changes
from the patch, because it does not work in all cases (almost in no cases to be 
honest).

Original comment by christian.koestlin on 14 Jan 2009 at 6:15

GoogleCodeExporter commented 8 years ago
I'm going to create a different issue to cover drawing a local cursor-- it's 
going to
need a more complicated implementation and we'll make it a user option

Original comment by googlec...@antlersoft.com on 15 Jan 2009 at 6:21

GoogleCodeExporter commented 8 years ago
I think you are right. I just wanted to play around with the Xor mode, but it 
would
be better to just draw a second bitmap at the right position over the other 
bitmap. I
don't think the ImageView will be able to handle this.

Original comment by christian.koestlin on 15 Jan 2009 at 6:33

GoogleCodeExporter commented 8 years ago
wow ... the new table layout looks great.

Original comment by christian.koestlin on 17 Jan 2009 at 6:59

GoogleCodeExporter commented 8 years ago
Fixed in 090125

Original comment by googlec...@antlersoft.com on 25 Jan 2009 at 8:43