search

AltBeacon / android-beacon-library

Allows Android apps to interact with BLE beacons
Apache License 2.0
2.83k stars 834 forks source link

Clarify material design dependency #1048

Closed liedQM closed 2 years ago

liedQM commented 2 years ago

Expected behavior

A library without UI should not depend on a UI framework like the material design library. https://material.io/develop/android/docs/getting-started

Actual behavior

The library depends on 'com.google.android.material:material:1.3.0'.

Android Beacon Library version

2.17.1 didn't have a material design dependency Starting from 2.18 the library depends on material design.

We are using your beacon scanner library in one of our libraries which also have no UI and the change enforces our library to also depend on an UI framework which actually makes no sense in my opinion.

I like to ask here: Why does the library depend on the material design library without having any UI component or any mention of the design library in the code?

liedQM commented 2 years ago

I can't even find any usage of com.google.android.material in your repository: com.google.android.material&type=code

davidgyoung commented 2 years ago

What makes you say “The library depends on 'com.google.android.material:material:1.3.0'”? There is certainly no intention that this be true.

liedQM commented 2 years ago

Your pom tells me otherwise: https://repo1.maven.org/maven2/org/altbeacon/android-beacon-library/2.19/android-beacon-library-2.19.pom

<dependency>
<groupId>com.google.android.material</groupId>
<artifactId>material</artifactId>
<version>1.3.0</version>
</dependency>

You can also see it here: https://mvnrepository.com/artifact/org.altbeacon/android-beacon-library/2.18

davidgyoung commented 2 years ago

Fixed in #1049