Fix crash on scan state restore.

AltBeacon / android-beacon-library

Allows Android apps to interact with BLE beacons

Apache License 2.0

2.83k stars 834 forks source link

Fix crash on scan state restore. #1131

Open davidgyoung opened 1 year ago

davidgyoung commented 1 year ago

This is a work in progress on fixing problems in #1129.

Changes compile and unit tests still pass, but end-to-end testing has not started.

paolorotolo commented 1 year ago

So I did some tests with multiple files and it correctly marks them as corrupted or skips them for excessive size. It seems it's working fine.

davidgyoung commented 1 year ago

This is being published as 2.19.6-beta3. It will be in a non-beta release after I verify it fixes crashes in production in an app published to Google Play.

liedQM commented 1 month ago

@davidgyoung any update on this PR? I guess the verifying should have taken place now? Can you please also have a look, why restore is called from the MainThread causing ANRs? The restore is accessing a file so doing an IO operation and should never be called from the MainThread.

See here: https://github.com/AltBeacon/android-beacon-library/issues/1189 We've observed a similar issue