search

AltBeacon / windows-beacon-library

Tools for working with beacons on Windows
Apache License 2.0
33 stars 14 forks source link

Logger #2

Open furkanvarol opened 9 years ago

furkanvarol commented 9 years ago

Hey @davidgyoung,

Like I mentioned in #1, LogManager is not implemented. I am planing to implement it first and NLog is different than Android Logger. Even, I think there is no need for an additional LogManager since NLog is configurable by its conf file. What do you think about it ? Should I do it in NLog way or same as Android ?

davidgyoung commented 9 years ago

Let's keep things simple until there is a compelling reason to do otherwise. NLog should be fine for now.

furkanvarol commented 9 years ago

There is a little problem with NLog. Last night I have faced an issue related to NLog supported targets. Since I created a Portable Class Library Project, I can not add NLog. For now, I implemented logger with System.Diagnostics.Debug but I think I need to make sure that I am doing in a right way. Let me clarify things for you (btw, it is similar to what we have in android library).

So, there are two option to create a library project:

  1. Class Library (I believe which only supports Windows platform not mobile nor Metro apps nor CE)
  2. Class Library Portable (which supports lots of .Net platform including Silverlight etc.)

So, I thought that Portable will be better but it came with some caveats. The first problem was BigInteger in Identifier, because of it I had to remove Windows Phone 8 platform. And now I have faced second problem on Portable Library project. For now, NLog does not support (actually I have checked their repo and I saw that they working on it and it seems like it is going to take a while) Portable Library. So, I thought you need to decide on this since it will affect the whole project.

Sorry for the confussion and taking your time, since I am not a .Net developer I couldn't know what problems I will face so time to time I will need to take your opinion.

Btw, you can check difference between Class Library and Class Library Portable by MSDN, StackOverflow and a Blog.

davidgyoung commented 9 years ago

I suspect whatever we do will have to change when Windows 10 is released, which will be the main target of this code (both for phones and for desktop Windows 10), because this is the first platform with native beacon support. It is unclear whether Windows 10 will use Portable Class Libraries to allow code to work on both platforms. I see almost no reason to make code that will run on Windows 8.x mobile.

I therefore think it is reasonable to start with a regular Class Library.

Major caveat: My Windows dev skills are very rusty. My last C# app was 9 years ago.

furkanvarol commented 9 years ago

Okay, I will try to convert project type than. Btw, portable library also supports metro apps which makes me think about it.