search

AltF02 / x11-rs

Rust bindings for X11 libraries
https://docs.rs/x11
MIT License
206 stars 66 forks source link

Missing Xkb types #49

Closed Ralith closed 8 years ago

Ralith commented 8 years ago

The various Xkb* events and flags don't seem to be bound. These are needed for reliable keyboard handling with xkbcommon-x11. It's easy to work around this by defining whatever you need locally and using transmute, but that leads to duplication of effort. The planned move to autogenerated bindings (#40) should fix this, but I thought I'd make a note anyway.

ghost commented 8 years ago

I should be able to get on this tomorrow. Unfortunately, I'm waiting for untagged unions to become stable before moving to generated bindings.

ghost commented 8 years ago

@Ralith 33be439 Are these the types and constants you were looking for?

Ralith commented 8 years ago

Thanks! That's the types I needed. However, it looks like you missed the event type and event type mask constants (such as XkbMapNotify and XkbMapNotifyMask) starting around line 69 of X11/extensions/XKB.h (from kbproto).

ghost commented 8 years ago

86d346b Sorry for the delayed response. I've been working two jobs, so my time for programming has been limited :( I'll publish these changes if that's everything you needed.

Ralith commented 8 years ago

That looks like all the stuff I need, thanks!

No worries about the delay, if I couldn't wait I'd have made a PR. Fortunately Rust makes it pretty easy to bodge this stuff. Thanks for all your work!

ghost commented 8 years ago

Thanks and published!