AltSchool / dynamic-rest

Dynamic extensions for Django REST Framework
MIT License
820 stars 107 forks source link

Update to work with Django 4.0.* & 4.1.* #339

Closed JackAtOmenApps closed 1 year ago

JackAtOmenApps commented 1 year ago

Updated dependencies

Updated tests

Other

JackAtOmenApps commented 1 year ago

@aleontiev @suavesav @chdastolfo this PR should bring just about everything in the package up-to-date until April 2023 when Django 4.2 LTS comes out.

If you have any questions, concerns, or recommendations for this PR, please let me know. Thank you!

aleontiev commented 1 year ago

@OmenApps thanks for your contribution. Changes look ok, but tox is failing on many builds:

suavesav commented 1 year ago

yep, can drop 3.6!

JackAtOmenApps commented 1 year ago

Hopefully fixed all issues

Looks like tests can't run. Got the following error: "Could not find a usable config.yml, you may have revoked the CircleCI OAuth app. Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline."

0x0645 commented 1 year ago

Hi, I was wondering if these changes will get merged anytime soon.

lihuafractadevops commented 1 year ago

When can we merge this feature? There are several pending issues from this issue. Thanks in advance.

JackAtOmenApps commented 1 year ago

@aleontiev Any update on use of CircleCI? Errors out with "Could not find a usable config.yml, you may have revoked the CircleCI OAuth app."

esp4ik commented 1 year ago

Any updates? :)

JackAtOmenApps commented 1 year ago

Bumping. @aleontiev or @suavesav can we push this?

aleontiev commented 1 year ago

@OmenApps let me take a look at the Circle config issue; once we can fix the pipeline this should be good to go

aleontiev commented 1 year ago

@OmenApps I've resolved conflicts with master and re-triggered the tests (we are on Github Actions now, Circle is no longer relevant here) but still seeing some failing tests:

https://github.com/AltSchool/dynamic-rest/actions/runs/3499817258/jobs/5861799360

Some are on Python 3.6, which can be dropped. But some on 3.7, 3.8, 3.9 with Django 4.x

Mathieu-Dirkx commented 1 year ago

I'm waiting on this to merge, so I took a look at what is keeping this from merging.

Looking in to the failed tests I notice that many of the failed tests for python 3.6 and 3.7 will never pass. Django 4.0 and above does not support Python 3.6 and 3.7, Django 3.2 is the last series to support Python 3.6 and 3.7 Link to the announcement: https://docs.djangoproject.com/en/4.0/releases/4.0/#python-compatibility

esp4ik commented 1 year ago

Seems that I've mistaken about source of problem. So, I just removed my previous comment.

More deep dive gives next: DRF supports Django 4 since 3.13 see release notes

Therefore, in addition to @Mathieu-Dirkx I would like to suggest also drop DRF < 3.13 (or 3.12 since dynamic_rest tests run successfully)

Abhi5h3k commented 1 year ago

dynamic-rest 2.1.2 requires Django<4,>=2.2, but you have django 4.1.5 which is incompatible.

Hey, Is there any solution for now? Need to upgrade my project to Django 4+

aleontiev commented 1 year ago

Opened a new PR here with test matrix fixes: #345

Thanks @Mathieu-Dirkx and @esp4ik for your insight into the compatibility issues and apologize for the delay; at AltSchool we are still on Django 3 so we haven't been focused on Django 4 compatibility yet; for this reason, we still have to support the combination of Py3.7/DRF3.11/Dj3 which probably looks rather outdated from the perspective of newer projects :)

threewordphrase commented 5 months ago

When will this release be published? We are coming up on EOL for Django 3.2 soon.