AltThree / Emoji

An emoji parser for Laravel 5.
https://alt-three.com/
MIT License
74 stars 7 forks source link

Dependency version issues. #11

Closed DxCat closed 8 years ago

DxCat commented 9 years ago

This package is having a lot of version incompatibility for me, but the most important things would be

"graham-campbell/markdown": "~4.0", //while the latest are 5.0

also, i'm wondering if you would make this compatible with laravel 5.0 too. Would love to have this package in my project

GrahamCampbell commented 9 years ago

Yeh, we don't work on markdown 5.0 yet.

jbrooksuk commented 9 years ago

It's compatible with Laravel 5, since we're using it with Cachet.

GrahamCampbell commented 9 years ago

4.x and 3.x of my markdown package both work on L5 though. :)

GrahamCampbell commented 9 years ago

We're not supporting L5.0 though, since it's EOL. Only 5.1 is the current version.

GrahamCampbell commented 9 years ago

The only change in markdown 5.x was the upgrade to parsedown 0.11, which might break this package. I need to look into that, and get us upgraded.

DxCat commented 9 years ago

I see. alright thanks for the fast response. Guess i should really upgrade my project to L5.1 soon and replace the outdated packages.

skcin7 commented 8 years ago

Here's my terminal:

$ sudo composer require alt-three/emoji
Password:
Using version ^3.0 for alt-three/emoji
./composer.json has been updated
> php artisan clear-compiled
Loading composer repositories with package information
Updating dependencies (including require-dev)
Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - alt-three/emoji v3.0.0 requires league/commonmark ^0.13 -> satisfiable by league/commonmark[0.13.0].
    - alt-three/emoji v3.0.1 requires league/commonmark ^0.13 -> satisfiable by league/commonmark[0.13.0].
    - Conclusion: don't install league/commonmark 0.13.0
    - Installation request for alt-three/emoji ^3.0 -> satisfiable by alt-three/emoji[v3.0.0, v3.0.1].

Installation failed, reverting ./composer.json to its original content.

I'm using Laravel 5.1.27. What can be done about this? I tried installing (via composer) league/commonmark which fails too. I just want this working as an example of how to extend CommonMark.

GrahamCampbell commented 8 years ago

What does your composer.json look like?

skcin7 commented 8 years ago

Looks like this:

{
    "name": "laravel/laravel",
    "description": "The Laravel Framework.",
    "keywords": ["framework", "laravel"],
    "license": "MIT",
    "type": "project",
    "require": {
        "php": ">=5.5.9",
        "laravel/framework": "5.1.*",
        "intervention/image": "^2.2",
        "graham-campbell/markdown": "^5.0",
        "backup-manager/backup-manager": "^1.0",
        "league/flysystem-dropbox": "^1.0",
        "backup-manager/laravel": "^1.0",
        "guzzlehttp/guzzle": "^6.1",
        "fabpot/goutte": "^3.1",
        "vinkla/instagram": "^3.2"
    },
    "require-dev": {
        "fzaninotto/faker": "~1.4",
        "mockery/mockery": "0.9.*",
        "phpunit/phpunit": "~4.0",
        "phpspec/phpspec": "~2.1"
    },
    "autoload": {
        "classmap": [
            "database"
        ],
        "psr-4": {
            "App\\": "app/"
        },
        "files": [
            "app/Http/helpers.php"
        ]
    },
    "autoload-dev": {
        "classmap": [
            "tests/TestCase.php"
        ]
    },
    "scripts": {
        "post-install-cmd": [
            "php artisan clear-compiled",
            "php artisan optimize"
        ],
        "pre-update-cmd": [
            "php artisan clear-compiled"
        ],
        "post-update-cmd": [
            "php artisan optimize"
        ],
        "post-root-package-install": [
            "php -r \"copy('.env.example', '.env');\""
        ],
        "post-create-project-cmd": [
            "php artisan key:generate"
        ]
    },
    "config": {
        "preferred-install": "dist"
    }
}

The "alt-three/emoji": "^3.0" string is added to the "require" object when I initiate the composer require, but is auto-removed when the composer require fails.

GrahamCampbell commented 8 years ago

"graham-campbell/markdown": "^6.0" is needed, not ^5.0. ;)

GrahamCampbell commented 8 years ago

We recently made some breaking changes as did commonmark so that's why alt-three emoji and markdown recently had new major releases.

skcin7 commented 8 years ago

Cool. It works now. I can proceed now with getting the alt-three/emojij CommonMark extension working. Thank you for quickly replying. :)

GrahamCampbell commented 8 years ago

No problem. :)