search

Altaba77 / ngx-walkthrough

A walkthrough/on-boarding/tour guide/learning page component which is responsive, dynamic, easy to use
MIT License
8 stars 8 forks source link

Cannot find module '@angular/core/src/metadata/lifecycle_hooks' in Angular 8. #10

Closed antoinedelia closed 5 years ago

antoinedelia commented 5 years ago

Hi,

I've just installed this package in my Angular 8 application, and I got the following error:

ERROR in node_modules/ngx-walkthrough/components/walkthrough.component/walkthrough.component.d.ts(2,81): error TS2307: Cannot find module '@angular/core/src/metadata/lifecycle_hooks'

To get rid of the error, I had to make the following changes.

Before: import { AfterViewChecked, OnChanges, SimpleChanges, AfterContentChecked } from '@angular/core/src/metadata/lifecycle_hooks';

After: import { AfterViewChecked, OnChanges, SimpleChanges, AfterContentChecked } from '@angular/core';

Could you update the package to get rid of the error please?

Thanks!

antoinedelia commented 5 years ago

I created a pull request that should fix the error

Altaba77 commented 5 years ago

Hello,

I merged the correction, thx for your help.

I also released a new version with the correctif -> 0.3.1.