search

Altaba77 / ngx-walkthrough

A walkthrough/on-boarding/tour guide/learning page component which is responsive, dynamic, easy to use
MIT License
8 stars 8 forks source link

add focus-element-interactive making focus element usable #3

Closed DoryZi closed 6 years ago

DoryZi commented 6 years ago

This is some refactors for tslint fixed, and more added support for making the focus element usable. As right now the walkthrough covers it, this helps it work better, as it brings it to the front, then moves it back to the original z-index.

DoryZi commented 6 years ago

Sure I can add to the readme. I did add a style, but I'm not using the scss as I saw it's all form the inline. Why is it all from the inline btw?

DoryZi commented 6 years ago

Other changes done, please review, or maybe we can just merge? :)

Altaba77 commented 6 years ago

Thx for your help

DoryZi commented 6 years ago

Thanks for providing this module, it's a cool migration. I would suggest you install webstorm and run some tslint through it, it suggestes lots of edits. Plus move over to none inline styles. I started working on having support for multiple elements to be selected, not easy.