Altai-man / docs.raku.org

Source code of a beta version of the updated docs.raku.org website
Artistic License 2.0
11 stars 6 forks source link

Retrieve pages of a category in alphabetical order of the title. #80

Closed 2colours closed 1 year ago

2colours commented 1 year ago

Hello,

I intend this modification to fix https://github.com/Altai-man/docs.raku.org/issues/72. As far as I could understand the issue, this modification could be sufficient; it definitely changes the category-items of the language site to alphabetical ordering.

This seemed to be the right place to intervene because this is where category items are retrieved and stored. I see no major disadvantages to always retrieve them as sorted - I rather see advantages if anything but of course this is not the only solution.

Altai-man commented 1 year ago

No, wait...

I like the commit addressing the issue, but why adding submodules in the same commits?

2colours commented 1 year ago

The what? :D Definitely unintended either way.

Altai-man commented 1 year ago

The what? :D Definitely unintended either way.

That's what I see in the commit's diff in github interface:

изображение

While only 1 file must be affected. :)

I agree handling of dependencies is less than awesome, but submodules are hardly a solution IMO.

2colours commented 1 year ago

Yeah no idea why those are there.

2colours commented 1 year ago

Can I add them to the .gitignore for convenience?

Altai-man commented 1 year ago

Not sure if it fits .gitignore, really. But to merge this we first need to re-do the commit without them, yes.

2colours commented 1 year ago

I'd prefer them to be added to .gitignore if there is no intention to ever take them into this repo.

Anyway, for now, I amended the commit so it should be good to go.

Altai-man commented 1 year ago

Anyway, for now, I amended the commit so it should be good to go

Thanks!

As for the .gitignore, for me it's up to a setup. The directories are not created automatically in such a way, but has to be set up this way to get into the commit.

For example, when I work, I have the libs in the sibling directories and load them via -I../Documentable... way, so there is no way something will get into the commit form there. That's why it feels like a personal preference to me.

2colours commented 1 year ago

Well, two things:

  1. I followed the described setup procedure so in this sense it's not exactly "personal".
  2. The other question is "why not", i.e what problems could it cause if these folders were downright ignored if they happen to be in the repo. And for that, I said, as long as we aren't planning to integrate them, and perhaps don't plan folders with those names, I see no disadvantages. So even the slightest advantage is a net win.
Altai-man commented 1 year ago

I followed the described setup procedure so in this sense it's not exactly "personal".

Ooooooh. You are correct, yes, the "manual" instruction will lead to the repos being cloned inside of the project directory.

So even the slightest advantage is a net win

Let's do it.