Closed 2colours closed 1 year ago
No, wait...
I like the commit addressing the issue, but why adding submodules in the same commits?
The what? :D Definitely unintended either way.
The what? :D Definitely unintended either way.
That's what I see in the commit's diff in github interface:
While only 1 file must be affected. :)
I agree handling of dependencies is less than awesome, but submodules are hardly a solution IMO.
Yeah no idea why those are there.
Can I add them to the .gitignore for convenience?
Not sure if it fits .gitignore, really. But to merge this we first need to re-do the commit without them, yes.
I'd prefer them to be added to .gitignore if there is no intention to ever take them into this repo.
Anyway, for now, I amended the commit so it should be good to go.
Anyway, for now, I amended the commit so it should be good to go
Thanks!
As for the .gitignore, for me it's up to a setup. The directories are not created automatically in such a way, but has to be set up this way to get into the commit.
For example, when I work, I have the libs in the sibling directories and load them via -I../Documentable...
way, so there is no way something will get into the commit form there. That's why it feels like a personal preference to me.
Well, two things:
I followed the described setup procedure so in this sense it's not exactly "personal".
Ooooooh. You are correct, yes, the "manual" instruction will lead to the repos being cloned inside of the project directory.
So even the slightest advantage is a net win
Let's do it.
Hello,
I intend this modification to fix https://github.com/Altai-man/docs.raku.org/issues/72. As far as I could understand the issue, this modification could be sufficient; it definitely changes the category-items of the language site to alphabetical ordering.
This seemed to be the right place to intervene because this is where category items are retrieved and stored. I see no major disadvantages to always retrieve them as sorted - I rather see advantages if anything but of course this is not the only solution.