search

Altair-Bueno / axum-template

Layers, extractors and template engine wrappers for axum based Web MVC applications
https://crates.io/crates/axum-template
MIT License
78 stars 6 forks source link

Support for minijinja-autoreload #42

Closed ngerakines closed 7 months ago

ngerakines commented 7 months ago

This PR includes support for the official minijinja-autoreload crate.

Altair-Bueno commented 7 months ago

Hi, thanks for your contribution! Would you mind taking a look at what is currently failing in CI? I believe it's related to the enabled features for minijinja. You might need to adjust the Makefile to run that particular example.

Also, could you please add an engine.rs and error.rs test? We already had nasty bugs related to those and I would appreciate if we had tests for minijinja-reload too.

ngerakines commented 7 months ago

I have the changes in the branch, but it looks like they aren't automatically being picked up in this PR. I may have to close this one and create a new one, but I'm going to give it a couple of hours to see if there is just some lag in the system.

Altair-Bueno commented 7 months ago

Thank you! The release should be available shortly on crates.io