search

Altalogy / tari

The Tari protocol
https://tari.com
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

feat: add help prompt functionality to merged mining #194

Closed corquaid closed 2 years ago

corquaid commented 2 years ago

Description

Motivation and Context

185

How Has This Been Tested?

Screenshot 2022-05-20 at 16 50 23 Screenshot 2022-05-20 at 16 50 36

https://user-images.githubusercontent.com/69508715/169555091-3ea85340-670a-4cc5-90e5-b7d5a0528f06.mov

https://user-images.githubusercontent.com/69508715/169555158-cd9d9dc0-91ea-49f8-9c94-8bb64c46a3a3.mov

tarnas14 commented 2 years ago

you'll probably not like it, but I've got two thoughts when looking at the last recording:

  1. the messages prompt should show after TBot animates in. I'm not saying that it should also be animated, but it should at least appear after TBot is ready, otherwise the feeling that TBot says those things is lost
  2. if there are 2 messages in the prompt, I think the first one should appear, then 3 dots for , then the next message, right?
corquaid commented 2 years ago

you'll probably not like it, but I've got two thoughts when looking at the last recording:

  1. the messages prompt should show after TBot animates in. I'm not saying that it should also be animated, but it should at least appear after TBot is ready, otherwise the feeling that TBot says those things is lost
  2. if there are 2 messages in the prompt, I think the first one should appear, then 3 dots for , then the next message, right?

This isn't covering the message animations at all, that's coming in another PR where I'll do the timing and sequencing with the loading dots, etc.

tarnas14 commented 2 years ago

you'll probably not like it, but I've got two thoughts when looking at the last recording:

  1. the messages prompt should show after TBot animates in. I'm not saying that it should also be animated, but it should at least appear after TBot is ready, otherwise the feeling that TBot says those things is lost
  2. if there are 2 messages in the prompt, I think the first one should appear, then 3 dots for , then the next message, right?

This isn't covering the message animations at all, that's coming in another PR where I'll do the timing and sequencing with the loading dots, etc.

ah! that makes sense then @2 if @1 is also coming in next PR I'm good

corquaid commented 2 years ago

I'm assuming changes in TBot animation come later

Yes 👍