Possible bug with Left 4 Dead 2 / app id 550

[vCybah]

Thanks for creating this script. It works great and I use it a lot. I noticed a small problem with the button that takes you to the game's cs.rin page. Specifically, when I go to the SteamDB page for L4D2 (https://steamdb.info/app/550/) while using script v1.1.4 and click the CS.RIN.RU button, I expect it to take me to this page (https://cs.rin.ru/forum/viewtopic.php?f=10&t=76079), which is the page for the game. This is what it would do with other games I've used the script with.

Instead, it takes me to this page (https://cs.rin.ru/forum/viewtopic.php?f=10&t=66199). Also, I noticed that the rin tag for this game is not displaying properly for me. It loads as an empty bracket, as shown here (https://imgur.com/a/lIU67r7), instead of saying [Info] like it does on the rin page. This works fine for other games I've tested. I tested this on two different installs of Firefox with ViolentMonkey 2.18.0 and no other scripts, and both behaved this way. I am not sure if this is a bug or a problem on my end, but I wanted to report it in case it is helpful. The script is very useful, so I thought it was worth mentioning. Let me know if you need more info.

--EDIT--

I just noticed this also is happening for the Portal game for me as well. The button on this page (https://steamdb.info/app/400/) directs to (https://cs.rin.ru/forum/viewtopic.php?f=10&t=66199), the same page as before, instead of (https://cs.rin.ru/forum/viewtopic.php?f=10&t=82159). The [Info] tag also is not properly displayed just like L4D2 is for me.

[Reddiepoint]

Hi Cybah, great to see you here.

Regarding the incorrect redirection, it's due to the way we search for topics. Due to the App ID being a common number (e.g. in AMD Phenom II X2 550) the script tries to look for the developer's name as well to try and narrow down the results, and just picks the first topic in the list. Unfortunately, by picking the top result it can lead to the wrong topic being chosen due to which topic has been posted in more recently. The URL used for L4D2 is https://cs.rin.ru/forum/search.php?keywords=550+Valve&fid%5B%5D=10&sr=topics&sf=firstpost (the search URLs are printed in the console). To improve detection, we could also check the topics and choose the one that contains the game name, otherwise it will default to the top one.

In terms of the tags not displaying properly, the [Info] tag is purposely omitted, however, there shouldn't be a set of empty brackets before the name. I don't see it on my screen though (tested with Edge and Firefox).

[vCybah]

Hi, thanks for the explanation! This makes so much sense, I thought it might have something to do with the dev of the game when I noticed that both games acting this way were from Valve, (I now realize this is just because Valve has low/common appid's usually) so I tested CS2 to see if it had the same issue and it didn't, it went right to the correct page on rin. However, now that I've made posts in the portal and l4d2 threads, clicking the button on SteamDB does indeed now take me to the correct pages as you say, since they've been chatted in more recently. I didn't even think to check the console, smh. Going to the search URL you linked and clicking on that "Grey Goo" game shows me the search options used there "550" & "Valve" and I guess it just ignores the 550 since it finds Valve in the first post because searching that thread for 550 returns nothing for me.

I obviously do not know anywhere near as much about this stuff as you guys do, my thought before was if it searched for a direct steam url in the first post, since most, if not all topics, (at-least ones that use the steam generated bbcode) have a direct link to the game on steam that it would be able to narrow it down better? Ex: searching for http://store.steampowered.com/app/400/Portal/ and only getting the threads where that link is in the first post, I would think it should only return the cs.rin.ru "portal" game page, my simple test of searching for the url directly didn't get parsed properly by the rin search bar and just returned a ton of results, I'm not sure if it's even possible, but that's what my thought was before, so I thought I'd mention it, but my apologies if it makes no sense/clearly won't work or makes things harder.

To improve detection, we could also check the topics and choose the one that contains the game name, otherwise it will default to the top one.

I would think this would probably be better and easier to do than my previous thought, I see you already implemented it and I will try it out and report back here shortly. (with a different link since I commented in those 2 threads previously mentioned, the v1.1.4 script pulls them up properly now.

In terms of the tags not displaying properly, the [Info] tag is purposely omitted, however, there shouldn't be a set of empty brackets before the name. I don't see it on my screen though (tested with Edge and Firefox).

The info tag being omitted was something I was unaware of, my apologies. Most games that I check the tags are displayed properly and if there is no tags it shows no tags/brackets. It's just those 2 I noticed displaying only brackets, but I'll keep testing, and it's not a big deal, there are no important tags in those 2 threads that really need to be displayed on SteamDB anyhow.

With my very limited testing this commit does seem to fix this issue. (i will call this 1.1.5 for now)

I installed a fresh copy of firefox, violentmonkey, and the script from the official 1.1.4 release. I installed the script from the commit linked that was just made to my current firefox install, I tested here (https://steamdb.info/app/570/) Dota 2 - Valve AppID: 570

The results:

v1.1.4: clicking the button takes me to (https://cs.rin.ru/forum/viewtopic.php?f=10&t=58967) v1.1.5/0d55f73: clicking the button takes me to (https://cs.rin.ru/forum/viewtopic.php?f=10&t=96696)

Also, on the 1.1.4 there are blank tags displayed for Dota 2 on SteamDB using my fresh install of firefox & 1.1.4, but using 1.1.5, the tags are displayed properly it seems as there are just none on the SteamDB page. (the rin page also only has the [Info] tag so this seems to be working properly if that tag is supposed to be omitted) not really sure what's up with that since you don't get the same results, but it's not a big deal as the normal tags work with 1.1.4 & 1.1.5 for me, see here (https://imgur.com/q7xELfI) & here (https://imgur.com/fcgABxv) - on 1.1.4 this one has empty brackets for me but not 1.1.5.

The results I got were with no other scripts enabled, also.

Console output of 1.1.4 & Dota 2 SteamDB page (https://imgur.com/JaEn30X)

Console output of 1.1.5 & Dota 2 SteamDB page (https://imgur.com/g2nBD2o) this was not a fresh install so I think the errors may be unrelated, see the below pic for the output of the 1.1.5 on the fresh install as it is different

Console output of 1.1.5 & Dota 2 SteamDB page + fresh install on firefox (https://imgur.com/xIW3ItS)

It seems to me like they are using the same URL's in the console but nonetheless one is working for me and the other isn't, even though all of the URL's it shows me, when I click on them Dota 2 is almost at the very bottom of the list, not sure whats up with that but it seems that this commit fixed the issue I was reporting because actually clicking the button is now going to the correct link even without it being the most recently chatted in topic shown in the results of the URL's it shows me.

Thank you very much!

P.S. I was writing this as I was testing and such so if some things I say at the top are corrected later or out of place or anything that's why.

[Reddiepoint]

Good to see the commit is working for you.

Going to the search URL you linked and clicking on that "Grey Goo" game shows me the search options used there "550" & "Valve" and I guess it just ignores the 550 since it finds Valve in the first post because searching that thread for 550 returns nothing for me.

Actually, there is a 550 in the update history (11. 2015.06.09. - Game is updated to v0.14.548548), but this illustrates the downsides of searching for common numbers.

my thought before was if it searched for a direct steam url in the first post, since most, if not all topics, (at-least ones that use the steam generated bbcode) have a direct link to the game on steam that it would be able to narrow it down better?

Yes, that's quite logical and in fact we tried this early on in development. However, this won't work since the URL is split up into many terms, so basically every page with a Steam link will return. We checked with RessourectoR and it's a problem with the CS.RIN search and we can't do anything about it.

this was not a fresh install so I think the errors may be unrelated, see the below pic for the output of the 1.1.5 on the fresh install as it is different

These errors should be okay, and you can ignore them. They aren't a result of the script and they shouldn't impact SteamDB. I personally get the yellow warnings, but sometimes I get the red ones too.

It seems to me like they are using the same URL's in the console but nonetheless one is working for me and the other isn't, even though all of the URL's it shows me, when I click on them Dota 2 is almost at the very bottom of the list, not sure whats up with that

That's because the fix I added goes through the resulting topics and checks if the title contains the game name, so the actual search URL is not affected. Theoretically, it should work as long as the title contains at least the name of the game as it is written in Steam/SteamDB/etc and also shows up on the first page of the results (which usually it is).

[vCybah]

Actually, there is a 550 in the update history (11. 2015.06.09. - Game is updated to v0.14.548548), but this illustrates the downsides of searching for common numbers.

You are correct, my bad, I didn't expand the spoilers when I did a quick search for 550 but I do see multiple results now that I actually look through it haha.

Yes, that's quite logical and in fact we tried this early on in development. However, this won't work since the URL is split up into many terms, so basically every page with a Steam link will return. We checked with RessourectoR and it's a problem with the CS.RIN search and we can't do anything about it.

Gotcha, when I searched for the URL on rin I got a ton of results and I wasn't sure if there was a way to "make it" search for it properly and not chop it into multiple terms via rin like regex or something, but that makes sense, thanks for clearing that up.

These errors should be okay, and you can ignore them. They aren't a result of the script and they shouldn't impact SteamDB. I personally get the yellow warnings, but sometimes I get the red ones too.

Awesome thanks, I just wasn't sure if it was from something in my setup causing it and I didn't get them with the "fresh install" so I assumed it was just on my end, but I put the pictures of both just to be safe.

That's because the fix I added goes through the resulting topics and checks if the title contains the game name, so the actual search URL is not affected. Theoretically, it should work as long as the title contains at least the name of the game as it is written in Steam/SteamDB/etc and also shows up on the first page of the results (which usually it is).

Sweet! Yeah it seems to be fully working as expected for me now using your fix, great work on this, and even though its unrelated to this/off topic, great work on MultiUp-Direct, I use that almost everyday as well, cheers!

Closing this since the issue has been fixed.