Alteqa / pe

0 stars 0 forks source link

Import does not work correctly when there is an error in the file #11

Open Alteqa opened 2 months ago

Alteqa commented 2 months ago

When importing this incorrect csv file, the error message shown is an error in parsing in the tags portion instead of something related to importation and does not help us to resolve the issue of error in the file or point us in the right direction. This is significant and import is one of the commonly used features of the app: image.png

image.png

soc-se-bot commented 2 months ago

Team's Response

The error that occurs is labeled as an error with the Events/Tags portion since during parsing, the first error that is seen is the empty Events cell, which should contain "N/A". The error description does state: "Make sure the first occurrence values match the correct format for the add command! (See UG for more details)", which helps to:

  1. Identify the potential cause as the first occurrence value, as is the case in the given example
  2. Guide one to the UG, upon reading which the formatting errors should become clear

Perhaps what the bug is trying to get at may be the fact that if multiple errors are present, the app does not tell you the exact specifications to change. However, I believe that while this may definitely be a possible improvement, it would probably lie beyond the scope of the iteration for a few reasons:

  1. If one were to follow the steps in the error message they would arrive at the UG, which would help to clarify a majority of the formatting issues
  2. Should issues still persist, the app already has differential classification of errors by field, specifying whether the issue is found in the VALUES/FIELDS/FORMATS areas
  3. The case of having an import file that is so differently formatted that the values are not even under the headings is quite unreasonable (in this case the file may have been from a bugged export, but this is beyond the scope of the bug, and upon manual inspection the formatting errors should become clear and easily fixed)

    Items for the Tester to Verify

    :question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: The error message here does not guide the user to the correct error as it merely mentions that there is a parsing issue. The issue is not clearly stated to originated from the file and it could be an issue within the software itself. Thus, this is problematic for anyone who uses the app consistently and is of high significance as it occurs virtually every time.