Alteqa / pe

0 stars 0 forks source link

Deleting 3 if there are both a contact named 3 and index 3 deletes only the index first #9

Open Alteqa opened 2 months ago

Alteqa commented 2 months ago

Instead of specifying which of the two options, the name or the index you want to delete, it always deletes the index first which is not specified in the UG:

image.png

image.png

nus-se-script commented 2 months ago

Team's Response

In our User Guide, we have explicitly stated the prohibition against naming contacts as numbers, accompanied by the rationale behind this restriction in the warning section of the add command. Given its placement in the warning section, it is crucial and expected that users thoroughly review it before executing any commands. The primary reason for disallowing the use of numeric names is to prevent confusion regarding which contact the application might delete. Furthermore, naming a person as a number is impractical in real-life scenarios. Even if such naming were attempted, recalling the identity of a contact solely by their numeric designation could lead to self-confusion. Screenshot 2024-04-20 at 3.13.40 PM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: In app, adding numbers as contacts is an entirely valid behaviour and does not produce to any errors or warnings whatsoever. You mentioned that it is not permitted but this is false as adding numbers as names is valid. As such, if a user wrongly enters a number as a persons contact, the system allows this. However, when the user realises this and tries to delete the contact with a number as a name, they will not know which contact will be deleted when using the delete command: the contact with the name 3 or the index 3.