search

AlternC / alternc-mailman

Mailman module for AlternC
2 stars 10 forks source link

Use PHP's e-mail validation filter to determine if list name is valid #28

Closed kienanstewart closed 1 year ago

kienanstewart commented 5 years ago

Fixes #27

camlafit commented 5 years ago

lgtm

Note: https://github.com/AlternC/AlternC/blob/b5b8bc30280fe2fc2de48ffe81d70a1479038825/bureau/class/functions.php#L244 to follow checkmail()

L-bryan commented 5 years ago

just for be sure , the '-' isn't problematic with the address create like LISTNAME-{owner|request|bounces|confirm| ..} in address table?

kienanstewart commented 5 years ago

I think in cases where the listname is something like example-owner, the actual aliases created will be

example-owner-owner, example-owner-request, etc.

If a list called exampe already exists, I think the alias example-owner will already exist and creation should fail.

However, this is worth confirming for sure.

On Wed, May 08, 2019 at 01:15:59AM -0700, L-bryan wrote:

just for be sure , the '-' isn't problematic with the address create like LISTNAME-{owner|request|bounces|confirm| ..} in address table?

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/AlternC/alternc-mailman/pull/28#issuecomment-490393838

lelutin commented 4 years ago

this would be interesting to fix since users usually expect to be able to have more valid characters.

however, the commit that actually added the limitation in 2016, c760e7a646d58714b6db7b893d8b49599066e8d8, did so in order to avoid shell command injection within the cronjob.

so if we don't want to regress back to that security issue, we should add to this PR a rewrite of the cronjob to a php script so that we avoid all of the nasty pitfalls that come from bash.