search

Alterplay / APAddressBook

Easy access to iOS address book
MIT License
1.38k stars 193 forks source link

Added Objective-C Nullability for Swift API Compatibility #76

Closed AnthonyMDev closed 8 years ago

AnthonyMDev commented 9 years ago

This pull request adds the nullability annotation to make API compatibility with Swift smoother.

AnthonyMDev commented 9 years ago

Note: Because this pull request will make API changes that will effect compatibility with older versions for Swift users, the version that includes this pull request should bump the major version of the framework. (Or, since it's still in beta, the minor version from 0.1 -> 0.2)

AnthonyMDev commented 9 years ago

The reason this is failing CI is because the Swift example project has not been updated to use the new version. @belkevich I don't want to waste my time fixing the example if this isn't going to make it into the repository. If you can confirm that you will accept this pull request, I'll happily make the changes to the example project.

belkevich commented 9 years ago

Hi! Sorry, for delay. We don't want to release the support of nullability right now. Because many developers prefer AppCode rather then XCode. And unfortunately AppCode IDE doesn't have full support of nullability now. But it will coming with next update. So, we'll accept your pull request. But a bit later.

keith commented 9 years ago

AppCode now supports this http://blog.jetbrains.com/objc/2015/06/new-appcode-3-2-eap-build-overrideimplement-for-swift-and-more/ it would be great if this could be merged if it's ready.

belkevich commented 9 years ago

Yup. I hope to release this feature on this weekend

keith commented 9 years ago

Any updates on this? It would be nice to include this with our iOS 9 builds.

Reflejo commented 9 years ago

Any updates?

belkevich commented 8 years ago

Merged. Please wait for release 0.2.0