search

Alterplay / APValidators

Codeless solution for form validation in iOS!
https://cocoapods.org/pods/APValidators
MIT License
131 stars 18 forks source link

added validation support for MDTextField from Material Controls for iOS #4

Closed emdzsi closed 8 years ago

emdzsi commented 8 years ago

Hi,

I've created an MDTextField category according to this issue, wrote recently: https://github.com/Alterplay/APValidators/issues/3

Please provide some feedback, if something isn't correct.

Best regards

codecov-io commented 8 years ago

Current coverage is 97.25% (diff: 100%)

Merging #4 into develop will not change coverage

@@            develop         #4   diff @@
==========================================
  Files            15         15          
  Lines           328        328          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits            319        319          
  Misses            9          9          
  Partials          0          0

Powered by Codecov. Last update 02f2cc2...00fb676

NickolaySheika commented 8 years ago

Hi

I've reviewed your pull request. Everything seems works regarding to validation.

But i've found that MDTextField is very buggy. And it has critical issue with memory management. APValidators override dealloc in custom categories to unsubscribe from KVO. With this issue this code will never be called because MDTextField has retain cycle and never will be released.

So i think we cannot not provide support for this control. You can still use it on your own in your private fork. Thank you for your time.