Alterran / CS-PropLineTool

Cities: Skylines Mod:
http://steamcommunity.com/sharedfiles/filedetails/?id=694512541
MIT License
5 stars 3 forks source link

Magic-number-esque in PropLineToolMod.cs #7

Open originalfoo opened 5 years ago

originalfoo commented 5 years ago

What is the purpose of BUILD_VERSION in PropLineToolMod.cs? When should it be changed? What should it be changed to? What happens if it gets changed? What happens if it doesn't get changed?

//TODO: Keep this up to date.
//Cannot automate using BuildDate.txt Resource as it does not reflect properly
public const string BUILD_VERSION = "190809";

If it's updated - ever - then it should not be a const (something that never changes, ever) but instead be changed to a readonly (something that gets changed at most once per build).

We could possibly automate the versioning as the mod dll doesn't need to be fully deterministic.

Also, what is purpose of BuildDate.txt?