Althrun-sun / used_car_market

An advanced used-car data visualization dashboard based on Python Dash
MIT License
0 stars 0 forks source link

Peer Review #1

Open Althrun-sun opened 1 year ago

CChCheChen commented 1 year ago

Hi @Althrun-sun,

I can only review your app by cloning the code and test it on my local.

First of all, the file path to load the data is not correct and it works after I updated to 'pd.read_csv("../data/car_price.csv")'.

Once the app loaded, a few improvement can be implemented.

  1. Filters should be placed in the section which user are easier to check, for example on top or on the left.
  2. Filters could be more responsible to update the plot, without clicking on the apply filter button
  3. The pie chart is not suitable to display the market share for each company, and this plot seems to no respond to the change in filters.

Overall, interesting app to play with!!!

Suraporn commented 1 year ago

Congratulations for the app!!

pengzh313 commented 1 year ago

It is a nice and meaningful visualization for people to explore the used vehicle market.

There are two things that might be considered for further improvement:

  1. Add a overall title for the app to give users a clear idea about what the app is doing if they do not have chance to see your repo.
  2. The pie chart seems not effective to distinguish so many car manufacturers by colours. Maybe a simple bar chart would be more effective if we want to see a ranking of market share of car manufacturers.