AltimateAI / vscode-dbt-power-user

This extension makes vscode seamlessly work with dbt™: Auto-complete, preview, column lineage, AI docs generation, health checks, cost estimation etc
https://www.altimate.ai
MIT License
452 stars 86 forks source link

Sweep: Preserve test configurations in Documentation Editor #1222

Closed sweep-ai[bot] closed 3 months ago

sweep-ai[bot] commented 3 months ago

Purpose

This pull request addresses an issue where the Documentation Editor was replacing the configuration of existing tests, causing tests with different configurations to be merged into a single test.

Description

The changes in this pull request ensure that the Documentation Editor preserves the existing test configurations when updating the documentation. Specifically:

  1. The getTestDataByColumn function has been updated to check if an existing test configuration exists for the current test. If an existing configuration is found, it is returned instead of creating a new one.
  2. The logic for handling relationship tests has been moved to a separate branch, ensuring that it does not interfere with the preservation of existing test configurations.
  3. The code for merging existing column data with the new column data has been updated to preserve the entire existing column object, including the tests, instead of selectively ignoring the tests.

Summary

The key changes in this pull request are:

Fixes #1219.


[!TIP] To get Sweep to edit this pull request, you can:

  • Comment below, and Sweep can edit the entire PR
  • Comment on a file, Sweep will only modify the commented file
  • Edit the original issue to get Sweep to recreate the PR from scratch

This is an automated message generated by Sweep AI.

sweep-ai[bot] commented 3 months ago

Sweep: PR Review

Author: sweep-ai[bot]

Sweep found 1 new issue.

Sweep has left comments on the pull request for you to review. You may respond to any comment Sweep made your feedback will be taken into consideration if you run the review again. If Sweep made a mistake, you can resolve the comment or let Sweep know by responding to the comment.

saravmajestic commented 3 months ago

Not right fix