Closed mdesmet closed 1 month ago
The changes in this pull request enhance project name management within the DBT integration classes. Key modifications include the addition of a private projectName
property with a default UUID in both DBTCloudProjectIntegration
and DBTCoreProjectIntegration
classes, along with new public methods getProjectName()
for retrieving the project name. The DBTProjectIntegration
interface is updated to require this method, and the getProjectName
method in DBTProject
is modified to return the project name from the integration instance instead of the project configuration.
File Path | Change Summary |
---|---|
src/dbt_client/dbtCloudIntegration.ts |
Added private projectName property and getProjectName() method; updated initializePaths() . |
src/dbt_client/dbtCoreIntegration.ts |
Introduced private projectName , findProjectName() method; updated refreshProjectConfig . |
src/dbt_client/dbtIntegration.ts |
Updated DBTProjectIntegration interface to include getProjectName() . |
src/manifest/dbtProject.ts |
Modified getProjectName to return project name from dbtProjectIntegration instance. |
dbt_core_integration.py
file, which is related to the DBT integration classes mentioned in the main PR, specifically in terms of enhancing the integration with the dbt framework.Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
@mdesmet since some of our functionalities like dbt docs collaboration store project name, will this affect that feature?
@mdesmet since some of our functionalities like dbt docs collaboration store project name, will this affect that feature?
It will but only in the case they use env vars, computed. It would not work correctly anyway in that case.
Overview
Problem
Describe the problem you are solving. Mention the ticket/issue if applicable.
Solution
Describe the implemented solution. Add external references if needed.
Screenshot/Demo
A picture is worth a thousand words. Please highlight the changes if applicable.
How to test
Checklist
README.md
updated and added information about my changeSummary by CodeRabbit